Skip to content

ci: Improve flaky test detector performance #7569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 22, 2023

We now run all tests into a single spawned process, which should hopefully speed this up a bit. We also reduce the # of repetitions from 100 to 50 to ensure we do not run overtime.

I noticed this is timing out on CI if there are a few changed tests as of now.

@mydea mydea added the Dev: CI label Mar 22, 2023
@mydea mydea requested review from Lms24 and AbhiPrasad March 22, 2023 14:27
@mydea mydea self-assigned this Mar 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.44 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.52 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.65 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.85 KB (-0.21% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.77 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.08 KB (+0.06% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.21 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.4 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.95 KB (0%)

We now run all tests into a single spawned process, which should hopefully speed this up a bit.
We also reduce the # of repetitions from 100 to 50 to ensure we do not run overtime.
@mydea mydea force-pushed the fn/better-flaky-test-detector branch from 462e52a to eb0cc3e Compare March 22, 2023 14:48
@mydea mydea merged commit aca5249 into develop Mar 22, 2023
@mydea mydea deleted the fn/better-flaky-test-detector branch March 22, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants