Skip to content

ci: Make E2E tests required & check for PRs against master #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 30, 2023

This makes the E2E tests required, and adds a job that checks if a branch is opened against master.

Opening this against master first to check if it works...

@mydea mydea added the Dev: CI label Mar 30, 2023
@mydea mydea requested review from lforst, Lms24 and AbhiPrasad March 30, 2023 11:29
@mydea mydea self-assigned this Mar 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023

⚠️ This PR is opened against master. You probably want to open it against develop.

@mydea
Copy link
Member Author

mydea commented Mar 30, 2023

Note: I also verified it does not re-create the commit if you keep pushing to the same PR. It should only add it once.

@mydea mydea changed the base branch from master to develop March 30, 2023 11:50
@mydea mydea marked this pull request as ready for review March 30, 2023 11:50
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea
Copy link
Member Author

mydea commented Mar 30, 2023

I updated this to:

  • ensure we do not run the flaky detector for PRs against master/develop
  • ensure the flaky detector scales to how many tests it detects. It will automatically reduce the amount of runs per test if more tests are in a single PR.

@AbhiPrasad AbhiPrasad closed this Mar 30, 2023
@AbhiPrasad
Copy link
Member

woooooooops

@AbhiPrasad AbhiPrasad reopened this Mar 30, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.62 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 64.4 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.15 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.78 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.53 KB (0%)
@sentry/browser - Webpack (minified) 72 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.55 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.05 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.21 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.4 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.74 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.86 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.45 KB (-0.01% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.49 KB (-0.01% 🔽)

@mydea mydea merged commit 1c009fa into develop Mar 30, 2023
@mydea mydea deleted the fn/ci-check branch March 30, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants