Skip to content

fix(remix): Remove unnecessary dependencies #7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Apr 2, 2023

Webpack and intergration are not used in remix app. Webpack even brings older cli version which makes sentry even bigger.

https://packagephobia.com/result?p=@sentry/[email protected]

image

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Webpack and intergration are not used in remix app.
Webpack even brings older cli version which makes sentry even bigger.
package.json Outdated
@@ -1,4 +1,5 @@
{
"packageManager": "[email protected]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"packageManager": "[email protected]",

We use Volta to manage our package manager and it's version. We should probably add this to our contributing docs!

@AbhiPrasad AbhiPrasad changed the title Cleanup remix deps fix(remix): Remove unnecessary dependencies Apr 3, 2023
@AbhiPrasad AbhiPrasad merged commit 74d1640 into getsentry:develop Apr 4, 2023
@AbhiPrasad
Copy link
Member

Thank you for your contribution @TrySound!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants