Skip to content

chore: Fix bug in changelog about runWithAsyncContext #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2023
Merged

chore: Fix bug in changelog about runWithAsyncContext #7873

merged 3 commits into from
Apr 17, 2023

Conversation

jeengbe
Copy link
Contributor

@jeengbe jeengbe commented Apr 17, 2023

Without this, errors slip past any app error handling and directly crash the process.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeengbe

The snippet was meant to be an example, but you're right that we should put some sensible error handling - you know as an error monitoring sdk 😄

@AbhiPrasad AbhiPrasad changed the title Fix bug in changelog migration guide chore: Fix bug in changelog about runWithAsyncContext Apr 17, 2023
@AbhiPrasad AbhiPrasad merged commit 7eaf461 into getsentry:develop Apr 17, 2023
@jeengbe
Copy link
Contributor Author

jeengbe commented Apr 17, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants