Skip to content

feat(tracing): Replace sentence style browser span keys with snake case #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 27, 2023
Merged

feat(tracing): Replace sentence style browser span keys with snake case #7978

merged 3 commits into from
Apr 27, 2023

Conversation

narsaynorath
Copy link
Member

@narsaynorath narsaynorath commented Apr 26, 2023 •
edited
Loading

Replaces "Encoded Body Size", "Decoded Body Size", and "Transfer Size" with keys agreed upon in getsentry/develop#920 (i.e. http.response_content_length, http.decoded_response_content_length, and http.transfer_size).

@narsaynorath
feat(perf-issues): Replace sentence style keys with snake case
80ee8f8 
Replaces old sentence style keys being used for browser spans with
snake case equivalents.
@narsaynorath narsaynorath changed the title Nar/feat/replace sentence style browser span keys with snake case feat(perf-issues): Replace sentence style browser span keys with snake case Apr 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.02 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.66 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.56 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 58.12 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (0%)
@sentry/browser - Webpack (minified) 69.07 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.04 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.6 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.83 KB (+0.03% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.81 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 40.59 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.62 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.57 KB (-0.01% 🔽)

@narsaynorath narsaynorath marked this pull request as ready for review April 27, 2023 14:18
@narsaynorath narsaynorath requested a review from AbhiPrasad April 27, 2023 14:18
@AbhiPrasad AbhiPrasad changed the title feat(perf-issues): Replace sentence style browser span keys with snake case feat(tracing): Replace sentence style browser span keys with snake case Apr 27, 2023
@narsaynorath
Copy link
Member Author

@AbhiPrasad just letting you know I've updated http.transfer_size -> http.response_transfer_size here

@narsaynorath narsaynorath merged commit 62c57a6 into develop Apr 27, 2023
@narsaynorath narsaynorath deleted the nar/feat/replace-sentence-style-browser-span-keys-with-snake-case branch April 27, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narsaynorath @AbhiPrasad