Skip to content

fix(replay): Keep session active on key press #8037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented May 4, 2023

This ensures the session remains active when a user presses a key.

This is a minimal implementation for now. IMHO we should maybe look into capturing key presses for keyboard shortcuts, but we need to make sure to avoid capturing user input into text fields this way etc.

Related to #6532

@mydea mydea added Type: Bug Package: replay Issues related to the Sentry Replay SDK labels May 4, 2023
@mydea mydea requested a review from billyvg May 4, 2023 08:47
@mydea mydea self-assigned this May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.01 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.62 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.55 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.08 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.16 KB (0%)
@sentry/browser - Webpack (minified) 69.03 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.18 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.09 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.64 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.86 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 46.91 KB (+0.09% 🔺)
@sentry/replay - Webpack (gzipped + minified) 40.71 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 65.79 KB (+0.09% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 58.69 KB (+0.1% 🔺)

@billyvg billyvg changed the title fix(replay: Keep page active on key press fix(replay): Keep page active on key press May 4, 2023
@billyvg billyvg changed the title fix(replay): Keep page active on key press fix(replay): Keep session active on key press May 4, 2023
@mydea mydea merged commit 3c00c68 into develop May 4, 2023
@mydea mydea deleted the fn/detect-keyboard branch May 4, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants