Skip to content

fix(tracing): Set correct parent span id on fetch sentry-trace header #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

AbhiPrasad
Copy link
Member

In slack we reported a bug where there seemed to be the wrong parent span id attached to outgoing sentry-trace headers: https://sentry.slack.com/archives/CDXAKMGTU/p1690830621077679

This ends up being because the addTracingHeadersToFetchRequest attempts to use the transaction instead of the active request span to generate the outgoing sentry-trace header.

This fixes that by adding the span to the addTracingHeadersToFetchRequest method.

@AbhiPrasad AbhiPrasad requested review from mydea and Lms24 July 31, 2023 20:23
@AbhiPrasad AbhiPrasad self-assigned this Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.1 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.41 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped) 21.95 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.83 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.29 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.33 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.03 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 60.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 30.41 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.16 KB (0%)
@sentry/react - Webpack (gzipped) 21.96 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.93 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.89 KB (+0.02% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) August 1, 2023 12:29
@AbhiPrasad AbhiPrasad merged commit f833ab2 into develop Aug 1, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-fetch-parent-child-fix branch August 1, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants