Skip to content

fix(core): Filter internal API frames for synthetic frames #8710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

kamilogorek
Copy link
Contributor

As well as fixes the ordering of operations and removes some redundant code.
The stack should be trimmed after filtering.

Fixes #8396

@kamilogorek kamilogorek requested review from a team, stephanie-anderson and Lms24 and removed request for a team August 2, 2023 09:22
@kamilogorek kamilogorek enabled auto-merge (squash) August 2, 2023 09:22
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.11 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.42 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped) 21.96 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.85 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.31 KB (+0.07% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.35 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.1 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.06 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 60.54 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 30.43 KB (+0.06% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.17 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 21.98 KB (+0.07% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.93 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.89 KB (-0.01% 🔽)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nice! 🚀

@kamilogorek
Copy link
Contributor Author

Got used to linters being auto-fixed in CI :(

@kamilogorek kamilogorek merged commit 6196bc5 into develop Aug 2, 2023
@kamilogorek kamilogorek deleted the filter-internal-frames branch August 2, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure usage of captureException() / captureMessage() with non-Error has correct top frame
2 participants