Skip to content

fix(replay): Ensure we debounce flush if replay too short #8716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 2, 2023

This fix ensures that if we try to flush a replay that is too short, we will debounce flush it again after the min. duration is reached.

@mydea mydea added Type: Bug Package: replay Issues related to the Sentry Replay SDK labels Aug 2, 2023
@mydea mydea requested a review from billyvg August 2, 2023 11:12
@mydea mydea self-assigned this Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 74.85 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.11 KB (0%)
@sentry/browser - Webpack (gzipped) 21.81 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.53 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.14 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.15 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.03 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.63 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.8 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 30.43 KB (-0.01% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.06 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 21.84 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.65 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.61 KB (0%)

@Lms24 Lms24 force-pushed the fn/replay-ensure-debounce-flush branch from 30947f6 to ad519d2 Compare August 3, 2023 07:53
@Lms24 Lms24 enabled auto-merge (squash) August 3, 2023 07:56
@Lms24 Lms24 merged commit b5f55a3 into develop Aug 3, 2023
@Lms24 Lms24 deleted the fn/replay-ensure-debounce-flush branch August 3, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants