Skip to content

chore(e2e-tests): Use Node 18 for E2E tests. #8964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version-file: 'package.json'
node-version-file: 'packages/e2e-tests/package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
env:
Expand All @@ -833,7 +833,7 @@ jobs:
- name: Get node version
id: versions
run: |
echo "echo node=$(jq -r '.volta.node' package.json)" >> $GITHUB_OUTPUT
echo "echo node=$(jq -r '.volta.node' packages/e2e-tests/package.json)" >> $GITHUB_OUTPUT

- name: Validate Verdaccio
run: yarn test:validate
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/Dockerfile.publish-packages
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This Dockerfile exists for the purpose of using a specific node/npm version (ie. the same we use in CI) to run npm publish with
ARG NODE_VERSION=16.19.0
ARG NODE_VERSION=18.17.1
FROM node:${NODE_VERSION}

WORKDIR /sentry-javascript/packages/e2e-tests
Expand Down
6 changes: 2 additions & 4 deletions packages/e2e-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
"name": "@sentry-internal/e2e-tests",
"version": "7.68.0",
"license": "MIT",
"engines": {
"node": ">=10"
},
"private": true,
"scripts": {
"fix": "run-s fix:eslint fix:prettier",
Expand Down Expand Up @@ -32,6 +29,7 @@
"yaml": "2.2.2"
},
"volta": {
"extends": "../../package.json"
"node": "18.17.1",
"yarn": "1.22.19"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"@playwright/test": "^1.27.1"
},
"volta": {
"node": "16.19.0",
"yarn": "1.22.19"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import type { PlaywrightTestConfig } from '@playwright/test';
import { devices } from '@playwright/test';

// Fix urls not resolving to localhost on Node v17+
// See: https://github.com/axios/axios/issues/3821#issuecomment-1413727575
import { setDefaultResultOrder } from 'dns';
setDefaultResultOrder('ipv4first');

const testEnv = process.env.TEST_ENV;

if (!testEnv) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
]
},
"volta": {
"node": "16.19.0",
"yarn": "1.22.19"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,8 @@
},
"engines": {
"node": ">=14"
},
"volta": {
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"@sentry/utils": "latest || *"
},
"volta": {
"node": "16.19.0",
"yarn": "1.22.19"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import type { PlaywrightTestConfig } from '@playwright/test';
import { devices } from '@playwright/test';

// Fix urls not resolving to localhost on Node v17+
// See: https://github.com/axios/axios/issues/3821#issuecomment-1413727575
import { setDefaultResultOrder } from 'dns';
setDefaultResultOrder('ipv4first');

const testEnv = process.env.TEST_ENV;

if (!testEnv) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"@playwright/test": "^1.27.1"
},
"volta": {
"node": "16.19.0",
"yarn": "1.22.19"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"serve": "14.0.1"
},
"volta": {
"node": "16.19.0",
"yarn": "1.22.19"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"serve": "14.0.1"
},
"volta": {
"node": "16.19.0",
"yarn": "1.22.19"
"extends": "../../package.json"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
"serve": "14.0.1"
},
"volta": {
"node": "16.19.0",
"yarn": "1.22.19"
"extends": "../../package.json"
}
}