Skip to content

feat(vue): Expose VueIntegration to initialize vue app later #9180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vue/src/errorhandler.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { getCurrentHub } from '@sentry/browser';
import { addExceptionMechanism } from '@sentry/utils';

import type { Options, ViewModel, Vue } from './types';
import type { ViewModel, Vue, VueOptions } from './types';
import { formatComponentName, generateComponentTrace } from './vendor/components';

type UnknownFunc = (...args: unknown[]) => void;

export const attachErrorHandler = (app: Vue, options: Options): void => {
export const attachErrorHandler = (app: Vue, options: VueOptions): void => {
const { errorHandler, warnHandler, silent } = app.config;

app.config.errorHandler = (error: Error, vm: ViewModel, lifecycleHook: string): void => {
Expand Down
1 change: 1 addition & 0 deletions packages/vue/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ export { init } from './sdk';
export { vueRouterInstrumentation } from './router';
export { attachErrorHandler } from './errorhandler';
export { createTracingMixins } from './tracing';
export { VueIntegration } from './integration';
99 changes: 99 additions & 0 deletions packages/vue/src/integration.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
import { hasTracingEnabled } from '@sentry/core';
import type { Hub, Integration } from '@sentry/types';
import { arrayify, GLOBAL_OBJ } from '@sentry/utils';

import { DEFAULT_HOOKS } from './constants';
import { attachErrorHandler } from './errorhandler';
import { createTracingMixins } from './tracing';
import type { Options, Vue, VueOptions } from './types';

const globalWithVue = GLOBAL_OBJ as typeof GLOBAL_OBJ & { Vue: Vue };

const DEFAULT_CONFIG: VueOptions = {
Vue: globalWithVue.Vue,
attachProps: true,
logErrors: true,
hooks: DEFAULT_HOOKS,
timeout: 2000,
trackComponents: false,
};

/**
* Initialize Vue error & performance tracking.
*/
export class VueIntegration implements Integration {
/**
* @inheritDoc
*/
public static id: string = 'Vue';

/**
* @inheritDoc
*/
public name: string;

private readonly _options: Partial<VueOptions>;

public constructor(options: Partial<VueOptions> = {}) {
this.name = VueIntegration.id;
this._options = options;
}

/** @inheritDoc */
public setupOnce(_addGlobaleventProcessor: unknown, getCurrentHub: () => Hub): void {
this._setupIntegration(getCurrentHub());
}

/** Just here for easier testing */
protected _setupIntegration(hub: Hub): void {
const client = hub.getClient();
const options: Options = { ...DEFAULT_CONFIG, ...(client && client.getOptions()), ...this._options };

if (!options.Vue && !options.app) {
// eslint-disable-next-line no-console
console.warn(
`[@sentry/vue]: Misconfigured SDK. Vue specific errors will not be captured.
Update your \`Sentry.init\` call with an appropriate config option:
\`app\` (Application Instance - Vue 3) or \`Vue\` (Vue Constructor - Vue 2).`,
);
return;
}

if (options.app) {
const apps = arrayify(options.app);
apps.forEach(app => vueInit(app, options));
} else if (options.Vue) {
vueInit(options.Vue, options);
}
}
}

const vueInit = (app: Vue, options: Options): void => {
// Check app is not mounted yet - should be mounted _after_ init()!
// This is _somewhat_ private, but in the case that this doesn't exist we simply ignore it
// See: https://github.com/vuejs/core/blob/eb2a83283caa9de0a45881d860a3cbd9d0bdd279/packages/runtime-core/src/component.ts#L394
const appWithInstance = app as Vue & {
_instance?: {
isMounted?: boolean;
};
};

const isMounted = appWithInstance._instance && appWithInstance._instance.isMounted;
if (isMounted === true) {
// eslint-disable-next-line no-console
console.warn(
'[@sentry/vue]: Misconfigured SDK. Vue app is already mounted. Make sure to call `app.mount()` after `Sentry.init()`.',
);
}

attachErrorHandler(app, options);

if (hasTracingEnabled(options)) {
app.mixin(
createTracingMixins({
...options,
...options.tracingOptions,
}),
);
}
};
94 changes: 16 additions & 78 deletions packages/vue/src/sdk.ts
Original file line number Diff line number Diff line change
@@ -1,34 +1,7 @@
import { init as browserInit, SDK_VERSION } from '@sentry/browser';
import { hasTracingEnabled } from '@sentry/core';
import { arrayify, GLOBAL_OBJ } from '@sentry/utils';
import { defaultIntegrations, init as browserInit, SDK_VERSION } from '@sentry/browser';

import { DEFAULT_HOOKS } from './constants';
import { attachErrorHandler } from './errorhandler';
import { createTracingMixins } from './tracing';
import type { Options, TracingOptions, Vue } from './types';

const globalWithVue = GLOBAL_OBJ as typeof GLOBAL_OBJ & { Vue: Vue };

const DEFAULT_CONFIG: Options = {
Vue: globalWithVue.Vue,
attachProps: true,
logErrors: true,
hooks: DEFAULT_HOOKS,
timeout: 2000,
trackComponents: false,
_metadata: {
sdk: {
name: 'sentry.javascript.vue',
packages: [
{
name: 'npm:@sentry/vue',
version: SDK_VERSION,
},
],
version: SDK_VERSION,
},
},
};
import { VueIntegration } from './integration';
import type { Options, TracingOptions } from './types';

/**
* Inits the Vue SDK
Expand All @@ -37,56 +10,21 @@ export function init(
config: Partial<Omit<Options, 'tracingOptions'> & { tracingOptions: Partial<TracingOptions> }> = {},
): void {
const options = {
...DEFAULT_CONFIG,
_metadata: {
sdk: {
name: 'sentry.javascript.vue',
packages: [
{
name: 'npm:@sentry/vue',
version: SDK_VERSION,
},
],
version: SDK_VERSION,
},
},
defaultIntegrations: [...defaultIntegrations, new VueIntegration()],
...config,
};

browserInit(options);

if (!options.Vue && !options.app) {
// eslint-disable-next-line no-console
console.warn(
`[@sentry/vue]: Misconfigured SDK. Vue specific errors will not be captured.
Update your \`Sentry.init\` call with an appropriate config option:
\`app\` (Application Instance - Vue 3) or \`Vue\` (Vue Constructor - Vue 2).`,
);
return;
}

if (options.app) {
const apps = arrayify(options.app);
apps.forEach(app => vueInit(app, options));
} else if (options.Vue) {
vueInit(options.Vue, options);
}
}

const vueInit = (app: Vue, options: Options): void => {
// Check app is not mounted yet - should be mounted _after_ init()!
// This is _somewhat_ private, but in the case that this doesn't exist we simply ignore it
// See: https://github.com/vuejs/core/blob/eb2a83283caa9de0a45881d860a3cbd9d0bdd279/packages/runtime-core/src/component.ts#L394
const appWithInstance = app as Vue & {
_instance?: {
isMounted?: boolean;
};
};

const isMounted = appWithInstance._instance && appWithInstance._instance.isMounted;
if (isMounted === true) {
// eslint-disable-next-line no-console
console.warn(
'[@sentry/vue]: Misconfigured SDK. Vue app is already mounted. Make sure to call `app.mount()` after `Sentry.init()`.',
);
}

attachErrorHandler(app, options);

if (hasTracingEnabled(options)) {
app.mixin(
createTracingMixins({
...options,
...options.tracingOptions,
}),
);
}
};
8 changes: 6 additions & 2 deletions packages/vue/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ export type ViewModel = {
};
};

export interface Options extends TracingOptions, BrowserOptions {
export interface VueOptions extends TracingOptions {
/** Vue constructor to be used inside the integration (as imported by `import Vue from 'vue'` in Vue2) */
Vue?: Vue;

/** Vue app instance(s) to be used inside the integration (as generated by `createApp` in Vue3 ) */
/**
* Vue app instance(s) to be used inside the integration (as generated by `createApp` in Vue3).
*/
app?: Vue | Vue[];

/**
Expand All @@ -48,6 +50,8 @@ export interface Options extends TracingOptions, BrowserOptions {
tracingOptions?: Partial<TracingOptions>;
}

export interface Options extends BrowserOptions, VueOptions {}

/** Vue specific configuration for Tracing Integration */
export interface TracingOptions {
/**
Expand Down
68 changes: 68 additions & 0 deletions packages/vue/test/integration/VueIntegration.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
import { logger } from '@sentry/utils';
import { createApp } from 'vue';

import * as Sentry from '../../src';

const PUBLIC_DSN = 'https://username@domain/123';

describe('Sentry.VueIntegration', () => {
let loggerWarnings: unknown[] = [];
let warnings: unknown[] = [];

beforeEach(() => {
warnings = [];
loggerWarnings = [];

jest.spyOn(logger, 'warn').mockImplementation((message: unknown) => {
loggerWarnings.push(message);
});

jest.spyOn(console, 'warn').mockImplementation((message: unknown) => {
warnings.push(message);
});
});

afterEach(() => {
jest.resetAllMocks();
});

it('allows to initialize integration later', () => {
Sentry.init({ dsn: PUBLIC_DSN, defaultIntegrations: false, autoSessionTracking: false });

const el = document.createElement('div');
const app = createApp({
template: '<div>hello</div>',
});

// This would normally happen through client.addIntegration()
const integration = new Sentry.VueIntegration({ app });
integration['_setupIntegration'](Sentry.getCurrentHub());

app.mount(el);

expect(warnings).toEqual([]);
expect(loggerWarnings).toEqual([]);

expect(app.config.errorHandler).toBeDefined();
});

it('warns when mounting before SDK.VueIntegration', () => {
Sentry.init({ dsn: PUBLIC_DSN, defaultIntegrations: false, autoSessionTracking: false });

const el = document.createElement('div');
const app = createApp({
template: '<div>hello</div>',
});

app.mount(el);

// This would normally happen through client.addIntegration()
const integration = new Sentry.VueIntegration({ app });
integration['_setupIntegration'](Sentry.getCurrentHub());

expect(warnings).toEqual([
'[@sentry/vue]: Misconfigured SDK. Vue app is already mounted. Make sure to call `app.mount()` after `Sentry.init()`.',
]);
expect(loggerWarnings).toEqual([]);
});
});
Loading