Skip to content

feat(dev): Change yalc:publish to publish with a hash #9269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Oct 16, 2023

Adds --sig option to yalc:publish tasks to include a hash of file contents as part of package version. This allows us to cache bust and allows dev servers to hot reload in watch mode.

Adds `--sig` option to `yalc:publish` tasks to include a hash of file contents as part of package version. This allows us to cache bust and allows dev servers to hot reload in watch mode.
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, didn't know this option existed.

@billyvg billyvg marked this pull request as ready for review October 18, 2023 22:54
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 83.98 KB (+1.78% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 0 B (removed)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.57 KB (+3.06% 🔺)
@sentry/browser - Webpack (gzipped) 21.75 KB (+2.39% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 80.47 KB (+10.21% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.51 KB (+2.87% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.68 KB (+2.88% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 245.55 KB (+5.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.53 KB (-1.81% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.45 KB (-2.05% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.64 KB (+3.78% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.05 KB (+1.3% 🔺)
@sentry/react - Webpack (gzipped) 21.79 KB (+2.42% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.18 KB (+2.82% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.65 KB (+4.43% 🔺)

@billyvg billyvg merged commit 7935e78 into develop Oct 19, 2023
@billyvg billyvg deleted the dev-add-sig-option-for-yalc branch October 19, 2023 19:01
billyvg added a commit that referenced this pull request Nov 9, 2023
I missed some packages when doing #9269
billyvg added a commit that referenced this pull request Nov 16, 2023
I missed some packages when doing #9269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants