Skip to content

test(deno): Refer to local files in tests #9297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 19, 2023
Merged

test(deno): Refer to local files in tests #9297

merged 4 commits into from
Oct 19, 2023

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Oct 18, 2023

We cannot depend on the npm version of files in the deno tests because our typings are gonna drift apart.

This is an ugly "slap any onto everything" to unblock hack.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to get a lint rule disallowing this just for deno.

@lforst lforst merged commit 905a3a1 into develop Oct 19, 2023
@lforst lforst deleted the lforst-local-deno branch October 19, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants