Skip to content

fix(types): Remove typo with CheckInEnvelope #9303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix(types): Remove typo with CheckInEnvelope #9303

merged 1 commit into from
Oct 20, 2023

Conversation

AbhiPrasad
Copy link
Member

woops

@AbhiPrasad AbhiPrasad requested review from a team, stephanie-anderson and lforst and removed request for a team October 18, 2023 21:28
@AbhiPrasad AbhiPrasad changed the title fix(types): Remove type with CheckInEnvelope fix(types): Remove typo with CheckInEnvelope Oct 18, 2023
@AbhiPrasad AbhiPrasad force-pushed the abhi-checkin-envelope-typo branch from 71e718e to f52a33a Compare October 18, 2023 21:28
mydea
mydea reviewed Oct 19, 2023
View reviewed changes
packages/types/src/envelope.ts Outdated
@@ -34,7 +34,8 @@ export type EnvelopeItemType =
| 'profile'
| 'replay_event'
| 'replay_recording'
| 'check_in';
| 'check_in'
| 'statsd';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mixing in stuff from the other PR ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, rebased and fixed!

@AbhiPrasad AbhiPrasad force-pushed the abhi-checkin-envelope-typo branch from f52a33a to 4ce1e27 Compare October 19, 2023 17:05
@AbhiPrasad AbhiPrasad force-pushed the abhi-checkin-envelope-typo branch from 4ce1e27 to 4bc7f03 Compare October 19, 2023 17:06
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 82.52 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 71.66 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.64 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped) 21.25 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 73.02 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.69 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.08 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 233.77 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 87.1 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.73 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.45 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 82.98 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 21.28 KB (+0.04% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 99.38 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 47.54 KB (+0.02% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) October 19, 2023 17:43
@AbhiPrasad AbhiPrasad merged commit 54babf0 into develop Oct 20, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-checkin-envelope-typo branch October 20, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea left review comments

@lforst lforst lforst approved these changes

@stephanie-anderson stephanie-anderson Awaiting requested review from stephanie-anderson stephanie-anderson was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @mydea @lforst