Skip to content

test(e2e): Increase polling timeout from 30 to 90 seconds #9491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2023
Merged

test(e2e): Increase polling timeout from 30 to 90 seconds #9491

merged 3 commits into from
Nov 9, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 8, 2023

We talked about this a few times, maybe increasing the timeout here helps!

@mydea
test(e2e): Increase polling timeout from 30 to 45 seconds
7284473 
We get timeouts somewhat frequently, maybe this fixes it.
@mydea mydea requested review from billyvg and lforst November 8, 2023 15:46
@mydea mydea self-assigned this Nov 8, 2023
@mydea mydea force-pushed the fn/increase-e2e-timeout branch from d5565e0 to 1f470cb Compare November 8, 2023 16:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.25 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.49 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.98 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped) 21.3 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 61.83 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.1 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.24 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 194.91 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.32 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.3 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.81 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.61 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 21.34 KB (+0.03% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.35 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.13 KB (+0.02% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 15.98 KB (+1.06% 🔺)

@mydea mydea force-pushed the fn/increase-e2e-timeout branch from 1f470cb to f67e315 Compare November 8, 2023 16:37
@mydea mydea changed the title test(e2e): Increase polling timeout from 30 to 45 seconds test(e2e): Increase polling timeout from 30 to 60 seconds Nov 9, 2023
@lforst
Copy link
Contributor

lforst commented Nov 9, 2023

We could even do like 90 seconds, the tests are not flakey, it's just slow ingestion if they fail.

@mydea mydea changed the title test(e2e): Increase polling timeout from 30 to 60 seconds test(e2e): Increase polling timeout from 30 to 90 seconds Nov 9, 2023
@mydea mydea merged commit be44a21 into develop Nov 9, 2023
@mydea mydea deleted the fn/increase-e2e-timeout branch November 9, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@lforst lforst lforst approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @lforst @billyvg