Skip to content

feat(replay): Add canvas.type setting #9877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Dec 15, 2023

Defaults to webp instead of png. This will also allow quality to work.

Closes https://github.com/getsentry/team-replay/issues/326

Defaults to `webp` instead of `png`. This will also allow `quality` to work.

Closes getsentry/team-replay#326
@billyvg billyvg force-pushed the feat-replay-add-canvas-recording-type-option branch from 82ff9ea to bd44d0c Compare December 15, 2023 18:54
Copy link
Contributor

github-actions bot commented Dec 15, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.21 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.6 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.2 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.29 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.91 KB (0%)
@sentry/browser - Webpack (gzipped) 21.58 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.57 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.32 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.55 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.61 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.34 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.51 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.54 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.45 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.97 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped) 21.62 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.72 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.41 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.2 KB (0%)

@billyvg billyvg marked this pull request as ready for review December 15, 2023 19:29
@billyvg billyvg requested a review from a team December 15, 2023 19:29
@billyvg billyvg merged commit 84299d0 into develop Dec 18, 2023
@billyvg billyvg deleted the feat-replay-add-canvas-recording-type-option branch December 18, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants