Skip to content

Commit 8614807

Browse files
committed
Little simplification on queue job transaction context
1 parent 5d03709 commit 8614807

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

src/Sentry/Laravel/Tracing/EventHandler.php

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -295,24 +295,18 @@ protected function queueJobProcessingHandler(QueueEvents\JobProcessing $event):
295295
$context = new SpanContext;
296296
}
297297

298+
$resolvedJobName = $event->job->resolveName();
299+
298300
$job = [
299301
'job' => $event->job->getName(),
300302
'queue' => $event->job->getQueue(),
303+
'resolved' => $event->job->resolveName(),
301304
'attempts' => $event->job->attempts(),
302305
'connection' => $event->connectionName,
303306
];
304307

305-
// Resolve name exists only from Laravel 5.3+
306-
$resolvedJobName = method_exists($event->job, 'resolveName')
307-
? $event->job->resolveName()
308-
: null;
309-
310-
if ($resolvedJobName !== null) {
311-
$job['resolved'] = $resolvedJobName;
312-
}
313-
314308
if ($context instanceof TransactionContext) {
315-
$context->setName($resolvedJobName ?? $event->job->getName());
309+
$context->setName($resolvedJobName);
316310
$context->setSource(TransactionSource::task());
317311
}
318312

0 commit comments

Comments
 (0)