Some more testing and passing max_string_length

Author: Peter Uittenbroek

sentry_sdk/client.py

@@ -323,7 +323,11 @@ def _prepare_event(
         # Postprocess the event here so that annotated types do
         # generally not surface in before_send
         if event is not None:
-            event = serialize(event, request_bodies=self.options.get("request_bodies"))
+            event = serialize(
+                event,
+                request_bodies=self.options.get("request_bodies"),
+                max_string_length=self.options.get("max_string_length"),
+            )
 
         before_send = self.options["before_send"]
         if (

sentry_sdk/consts.py

@@ -42,7 +42,7 @@
 
 DEFAULT_QUEUE_SIZE = 100
 DEFAULT_MAX_BREADCRUMBS = 100
-
+DEFAULT_MAX_STRING_LENGTH = 1024
 MATCH_ALL = r".*"
 
 
@@ -197,7 +197,7 @@ def __init__(
         ],  # type: Optional[Sequence[str]]
         functions_to_trace=[],  # type: Sequence[Dict[str, str]]  # noqa: B006
         event_scrubber=None,  # type: Optional[sentry_sdk.scrubber.EventScrubber]
-        max_string_length=1024,  # type: int
+        max_string_length=DEFAULT_MAX_STRING_LENGTH,  # type: int
     ):
         # type: (...) -> None
         pass

sentry_sdk/utils.py

@@ -50,6 +50,7 @@
 import sentry_sdk
 from sentry_sdk._compat import PY2, PY33, PY37, implements_str, text_type, urlparse
 from sentry_sdk._types import TYPE_CHECKING
+from sentry_sdk.consts import DEFAULT_MAX_STRING_LENGTH
 
 if TYPE_CHECKING:
     from types import FrameType, TracebackType
@@ -75,7 +76,7 @@
 # The logger is created here but initialized in the debug support module
 logger = logging.getLogger("sentry_sdk.errors")
 
-MAX_STRING_LENGTH = 1024
+
 BASE64_ALPHABET = re.compile(r"^[a-zA-Z0-9/+=]*$")
 
 SENSITIVE_DATA_SUBSTITUTE = "[Filtered]"
@@ -736,7 +737,7 @@ def single_exception_from_error_tuple(
     if client_options is None:
         include_local_variables = True
         include_source_context = True
-        max_string_length = MAX_STRING_LENGTH  # fallback
+        max_string_length = DEFAULT_MAX_STRING_LENGTH  # fallback
     else:
         include_local_variables = client_options["include_local_variables"]
         include_source_context = client_options["include_source_context"]
@@ -1099,8 +1100,7 @@ def strip_string(value, max_length=None):
         return value
 
     if max_length is None:
-        # This is intentionally not just the default such that one can patch `MAX_STRING_LENGTH` and affect `strip_string`.
-        max_length = MAX_STRING_LENGTH
+        max_length = DEFAULT_MAX_STRING_LENGTH
 
     length = len(value.encode("utf-8"))
 

tests/test_client.py

@@ -24,7 +24,7 @@
 from sentry_sdk.utils import HAS_CHAINED_EXCEPTIONS
 from sentry_sdk.utils import logger
 from sentry_sdk.serializer import MAX_DATABAG_BREADTH
-from sentry_sdk.consts import DEFAULT_MAX_BREADCRUMBS
+from sentry_sdk.consts import DEFAULT_MAX_BREADCRUMBS, DEFAULT_MAX_STRING_LENGTH
 
 try:
     from unittest import mock  # python 3.3 and above
@@ -1029,3 +1029,18 @@ def test_multiple_positional_args(sentry_init):
     with pytest.raises(TypeError) as exinfo:
         sentry_init(1, None)
     assert "Only single positional argument is expected" in str(exinfo.value)
+
+
+@pytest.mark.parametrize(
+    "sdk_options, expected_data_length",
+    [({}, DEFAULT_MAX_STRING_LENGTH), ({"max_string_length": 2000}, 2000)],
+)
+def test_max_string_length_option(
+    sentry_init, capture_events, sdk_options, expected_data_length
+):
+    sentry_init(sdk_options)
+    events = capture_events()
+
+    capture_message("a" * 2000)
+
+    assert len(events[0]["message"]) == expected_data_length