Skip to content

Commit 64c42ca

Browse files
authored
fix(utils): Filter out empty string releases (#2591)
Instead of only allowing truthy releases, we were allowing all non-`None` releases, which includes empty strings.
1 parent 4731312 commit 64c42ca

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

sentry_sdk/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def get_default_release():
130130
return release
131131

132132
release = get_git_revision()
133-
if release is not None:
133+
if release:
134134
return release
135135

136136
for var in (

tests/test_utils.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from sentry_sdk.utils import (
66
Components,
77
Dsn,
8+
get_default_release,
89
get_error_message,
910
get_git_revision,
1011
is_valid_sample_rate,
@@ -579,3 +580,15 @@ def test_devnull_not_found():
579580
revision = get_git_revision()
580581

581582
assert revision is None
583+
584+
585+
def test_default_release():
586+
release = get_default_release()
587+
assert release is not None
588+
589+
590+
def test_default_release_empty_string():
591+
with mock.patch("sentry_sdk.utils.get_git_revision", return_value=""):
592+
release = get_default_release()
593+
594+
assert release is None

0 commit comments

Comments
 (0)