more aiohttp tests

Author: sentrivana

tests/integrations/aiohttp/test_aiohttp.py

@@ -18,12 +18,18 @@
     import mock  # python < 3.3
 
 
-def requires_python_version(major, minor, reason=None):
+def min_python_version(major, minor, reason=None):
     if reason is None:
-        reason = "Requires Python {}.{}".format(major, minor)
+        reason = "Requires Python {}.{} or higher".format(major, minor)
     return pytest.mark.skipif(sys.version_info < (major, minor), reason=reason)
 
 
+def max_python_version(major, minor, reason=None):
+    if reason is None:
+        reason = "Requires Python {}.{} or lower".format(major, minor)
+    return pytest.mark.skipif(sys.version_info > (major, minor), reason=reason)
+
+
 @pytest.mark.asyncio
 async def test_basic(sentry_init, aiohttp_client, capture_events):
     sentry_init(integrations=[AioHttpIntegration()])
@@ -544,7 +550,7 @@ async def handler(request):
         )
 
 
-@requires_python_version(3, 8, "GraphQL aiohttp integration requires py>=3.8")
+@min_python_version(3, 8, "GraphQL aiohttp integration requires py>=3.8")
 @pytest.mark.asyncio
 async def test_graphql_get_client_error_captured(
     sentry_init, capture_events, aiohttp_raw_server, aiohttp_client
@@ -594,7 +600,7 @@ async def handler(request):
     )
 
 
-@requires_python_version(3, 8, "GraphQL aiohttp integration requires py>=3.8")
+@min_python_version(3, 8, "GraphQL aiohttp integration requires py>=3.8")
 @pytest.mark.asyncio
 async def test_graphql_post_client_error_captured(
     sentry_init, capture_events, aiohttp_client, aiohttp_raw_server
@@ -654,3 +660,85 @@ async def handler(request):
         event["exception"]["values"][0]["value"]
         == "GraphQL request failed, name: AddPet, type: mutation"
     )
+
+
+@max_python_version(3, 7, "No GraphQL aiohttp integration for py<=3.7")
+@pytest.mark.asyncio
+async def test_graphql_get_client_error_not_captured(
+    sentry_init, capture_events, aiohttp_raw_server, aiohttp_client
+):
+    """Test that firing GraphQL requests works, there will just be no event."""
+    sentry_init(integrations=[AioHttpIntegration()])
+
+    graphql_response = {
+        "data": None,
+        "errors": [
+            {
+                "message": "some error",
+                "locations": [{"line": 2, "column": 3}],
+                "path": ["pet"],
+            }
+        ],
+    }
+
+    async def handler(request):
+        return json_response(graphql_response)
+
+    raw_server = await aiohttp_raw_server(handler)
+    events = capture_events()
+
+    client = await aiohttp_client(raw_server)
+    response = await client.get(
+        "/graphql", params={"query": "query GetPet {pet{name}}"}
+    )
+
+    assert response.status == 200
+    assert await response.json() == graphql_response
+    assert not events
+
+
+@max_python_version(3, 7, "No GraphQL aiohttp integration for py<=3.7")
+@pytest.mark.asyncio
+async def test_graphql_post_client_error_not_captured(
+    sentry_init, capture_events, aiohttp_client, aiohttp_raw_server
+):
+    """Test that firing GraphQL requests works, there will just be no event."""
+    sentry_init(integrations=[AioHttpIntegration()])
+
+    graphql_request = {
+        "query": dedent(
+            """
+            mutation AddPet ($name: String!) {
+                addPet(name: $name) {
+                    id
+                    name
+                }
+            }
+        """
+        ),
+        "variables": {
+            "name": "Lucy",
+        },
+    }
+    graphql_response = {
+        "data": None,
+        "errors": [
+            {
+                "message": "already have too many pets",
+                "locations": [{"line": 1, "column": 1}],
+            }
+        ],
+    }
+
+    async def handler(request):
+        return json_response(graphql_response)
+
+    raw_server = await aiohttp_raw_server(handler)
+    events = capture_events()
+
+    client = await aiohttp_client(raw_server)
+    response = await client.post("/graphql", json=graphql_request)
+
+    assert response.status == 200
+    assert await response.json() == graphql_response
+    assert not events