-
Notifications
You must be signed in to change notification settings - Fork 550
fix(profiling): Do not keep reference to frame #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4d89098
fix(profiling): Do not keep reference to frame
Zylphrex 141faba
fix tests
Zylphrex a5a43c7
adapted lru cache from python
Zylphrex a65a58e
remove prints
Zylphrex 68379f7
clean up typing
Zylphrex 3bab77f
Merge branch 'master' of github.com:getsentry/sentry-python into txia…
Zylphrex 133ed2b
clean up tests
Zylphrex 97580fc
run black
Zylphrex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,156 @@ | ||
""" | ||
A fork of Python 3.6's stdlib lru_cache (found in Python's 'cpython/Lib/functools.py') | ||
adapted into a data structure for single threaded uses. | ||
|
||
https://github.com/python/cpython/blob/v3.6.12/Lib/functools.py | ||
|
||
|
||
Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, | ||
2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020 Python Software Foundation; | ||
|
||
All Rights Reserved | ||
|
||
|
||
PYTHON SOFTWARE FOUNDATION LICENSE VERSION 2 | ||
-------------------------------------------- | ||
|
||
1. This LICENSE AGREEMENT is between the Python Software Foundation | ||
("PSF"), and the Individual or Organization ("Licensee") accessing and | ||
otherwise using this software ("Python") in source or binary form and | ||
its associated documentation. | ||
|
||
2. Subject to the terms and conditions of this License Agreement, PSF hereby | ||
grants Licensee a nonexclusive, royalty-free, world-wide license to reproduce, | ||
analyze, test, perform and/or display publicly, prepare derivative works, | ||
distribute, and otherwise use Python alone or in any derivative version, | ||
provided, however, that PSF's License Agreement and PSF's notice of copyright, | ||
i.e., "Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, | ||
2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020 Python Software Foundation; | ||
All Rights Reserved" are retained in Python alone or in any derivative version | ||
prepared by Licensee. | ||
|
||
3. In the event Licensee prepares a derivative work that is based on | ||
or incorporates Python or any part thereof, and wants to make | ||
the derivative work available to others as provided herein, then | ||
Licensee hereby agrees to include in any such work a brief summary of | ||
the changes made to Python. | ||
|
||
4. PSF is making Python available to Licensee on an "AS IS" | ||
basis. PSF MAKES NO REPRESENTATIONS OR WARRANTIES, EXPRESS OR | ||
IMPLIED. BY WAY OF EXAMPLE, BUT NOT LIMITATION, PSF MAKES NO AND | ||
DISCLAIMS ANY REPRESENTATION OR WARRANTY OF MERCHANTABILITY OR FITNESS | ||
FOR ANY PARTICULAR PURPOSE OR THAT THE USE OF PYTHON WILL NOT | ||
INFRINGE ANY THIRD PARTY RIGHTS. | ||
|
||
5. PSF SHALL NOT BE LIABLE TO LICENSEE OR ANY OTHER USERS OF PYTHON | ||
FOR ANY INCIDENTAL, SPECIAL, OR CONSEQUENTIAL DAMAGES OR LOSS AS | ||
A RESULT OF MODIFYING, DISTRIBUTING, OR OTHERWISE USING PYTHON, | ||
OR ANY DERIVATIVE THEREOF, EVEN IF ADVISED OF THE POSSIBILITY THEREOF. | ||
|
||
6. This License Agreement will automatically terminate upon a material | ||
breach of its terms and conditions. | ||
|
||
7. Nothing in this License Agreement shall be deemed to create any | ||
relationship of agency, partnership, or joint venture between PSF and | ||
Licensee. This License Agreement does not grant permission to use PSF | ||
trademarks or trade name in a trademark sense to endorse or promote | ||
products or services of Licensee, or any third party. | ||
|
||
8. By copying, installing or otherwise using Python, Licensee | ||
agrees to be bound by the terms and conditions of this License | ||
Agreement. | ||
|
||
""" | ||
|
||
SENTINEL = object() | ||
|
||
|
||
# aliases to the entries in a node | ||
PREV = 0 | ||
NEXT = 1 | ||
KEY = 2 | ||
VALUE = 3 | ||
|
||
|
||
class LRUCache(object): | ||
def __init__(self, max_size): | ||
assert max_size > 0 | ||
|
||
self.max_size = max_size | ||
self.full = False | ||
|
||
self.cache = {} | ||
|
||
# root of the circularly linked list to keep track of | ||
# the least recently used key | ||
self.root = [] # type: ignore | ||
# the node looks like [PREV, NEXT, KEY, VALUE] | ||
self.root[:] = [self.root, self.root, None, None] | ||
|
||
self.hits = self.misses = 0 | ||
|
||
def set(self, key, value): | ||
link = self.cache.get(key, SENTINEL) | ||
|
||
if link is not SENTINEL: | ||
# have to move the node to the front of the linked list | ||
link_prev, link_next, _key, _value = link | ||
|
||
# first remove the node from the lsnked list | ||
link_prev[NEXT] = link_next | ||
link_next[PREV] = link_prev | ||
|
||
# insert the node between the root and the last | ||
last = self.root[PREV] | ||
last[NEXT] = self.root[PREV] = link | ||
link[PREV] = last | ||
link[NEXT] = self.root | ||
|
||
# update the value | ||
link[VALUE] = value | ||
|
||
elif self.full: | ||
# reuse the root node, so update its key/value | ||
old_root = self.root | ||
old_root[KEY] = key | ||
old_root[VALUE] = value | ||
|
||
self.root = old_root[NEXT] | ||
old_key = self.root[KEY] | ||
|
||
self.root[KEY] = self.root[VALUE] = None | ||
|
||
del self.cache[old_key] | ||
|
||
self.cache[key] = old_root | ||
|
||
else: | ||
# insert new node after last | ||
last = self.root[PREV] | ||
link = [last, self.root, key, value] | ||
last[NEXT] = self.root[PREV] = self.cache[key] = link | ||
self.full = len(self.cache) >= self.max_size | ||
|
||
def get(self, key, default=None): | ||
link = self.cache.get(key, SENTINEL) | ||
|
||
if link is SENTINEL: | ||
self.misses += 1 | ||
return default | ||
|
||
# have to move the node to the front of the linked list | ||
link_prev, link_next, _key, _value = link | ||
|
||
# first remove the node from the lsnked list | ||
link_prev[NEXT] = link_next | ||
link_next[PREV] = link_prev | ||
|
||
# insert the node between the root and the last | ||
last = self.root[PREV] | ||
last[NEXT] = self.root[PREV] = link | ||
link[PREV] = last | ||
link[NEXT] = self.root | ||
|
||
self.hits += 1 | ||
|
||
return link[VALUE] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.