Skip to content

Add Django 4.2 to test suite #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Add Django 4.2 to test suite #2462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb27709
Add Django 4.2 to test suite
sentrivana Oct 24, 2023
d09b911
debug
sentrivana Oct 24, 2023
5a44b60
wip
sentrivana Oct 24, 2023
8771c9b
fix test
sentrivana Oct 24, 2023
da2cebc
test tweak
sentrivana Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/integrations/django/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,10 +647,11 @@ def test_db_connection_span_data(sentry_init, client, capture_events):
if span.get("op") == "db":
data = span.get("data")
assert data.get(SPANDATA.DB_SYSTEM) == "postgresql"
assert (
data.get(SPANDATA.DB_NAME)
== connections["postgres"].get_connection_params()["database"]
)
conn_params = connections["postgres"].get_connection_params()
assert data.get(SPANDATA.DB_NAME) is not None
assert data.get(SPANDATA.DB_NAME) == conn_params.get(
"database"
) or conn_params.get("dbname")
assert data.get(SPANDATA.SERVER_ADDRESS) == os.environ.get(
"SENTRY_PYTHON_TEST_POSTGRES_HOST", "localhost"
)
Expand Down
11 changes: 6 additions & 5 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ envlist =
{py3.6,py3.7,py3.8,py3.9}-django-v{3.0,3.1}
{py3.6,py3.7,py3.8,py3.9,py3.10,py3.11}-django-v{3.2}
# - Django 4.x
{py3.8,py3.9,py3.10,py3.11}-django-v{4.0,4.1}
{py3.8,py3.9,py3.10,py3.11}-django-v{4.0,4.1,4.2}

# Falcon
{py2.7,py3.5,py3.6,py3.7}-falcon-v{1.4}
Expand Down Expand Up @@ -289,10 +289,10 @@ deps =
django-v{2.2,3.0,3.1,3.2}: pytest-django>=4.0
django-v{2.2,3.0,3.1,3.2}: Werkzeug<2.0

django-v{4.0,4.1}: djangorestframework
django-v{4.0,4.1}: pytest-asyncio
django-v{4.0,4.1}: pytest-django
django-v{4.0,4.1}: Werkzeug
django-v{4.0,4.1,4.2}: djangorestframework
django-v{4.0,4.1,4.2}: pytest-asyncio
django-v{4.0,4.1,4.2}: pytest-django
django-v{4.0,4.1,4.2}: Werkzeug

django-v1.8: Django>=1.8,<1.9
django-v1.9: Django>=1.9,<1.10
Expand All @@ -306,6 +306,7 @@ deps =
django-v3.2: Django>=3.2,<3.3
django-v4.0: Django>=4.0,<4.1
django-v4.1: Django>=4.1,<4.2
django-v4.2: Django>=4.2,<4.3

# Falcon
falcon-v1.4: falcon>=1.4,<1.5
Expand Down