Skip to content

Commit 847fcc0

Browse files
authored
Merge branch 'main' into jenn/touch-events
2 parents 7b27fe3 + 8d3d9ae commit 847fcc0

File tree

11 files changed

+111
-111
lines changed

11 files changed

+111
-111
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- feat: Touch events now track components with `sentry-label` prop, falls back to `accessibilityLabel` and then finally `displayName`. #2068
66
- fix: Respect sentryOption.debug setting instead of #DEBUG build flag for outputting logs #2039
77
- fix: Passing correct mutableOptions to iOS SDK (#2037)
8+
- Bump: Bump @sentry/javascript dependencies to 6.17.9 #2082
89

910
## 3.2.14-beta.1
1011

package.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,20 @@
4040
"react-native": ">=0.56.0"
4141
},
4242
"dependencies": {
43-
"@sentry/browser": "6.12.0",
43+
"@sentry/browser": "6.17.9",
4444
"@sentry/cli": "^1.72.0",
45-
"@sentry/core": "6.12.0",
46-
"@sentry/hub": "6.12.0",
47-
"@sentry/integrations": "6.12.0",
48-
"@sentry/react": "6.12.0",
49-
"@sentry/tracing": "6.12.0",
50-
"@sentry/types": "6.12.0",
51-
"@sentry/utils": "6.12.0",
45+
"@sentry/core": "6.17.9",
46+
"@sentry/hub": "6.17.9",
47+
"@sentry/integrations": "6.17.9",
48+
"@sentry/react": "6.17.9",
49+
"@sentry/tracing": "6.17.9",
50+
"@sentry/types": "6.17.9",
51+
"@sentry/utils": "6.17.9",
5252
"@sentry/wizard": "^1.2.17"
5353
},
5454
"devDependencies": {
55-
"@sentry-internal/eslint-config-sdk": "6.12.0",
56-
"@sentry-internal/eslint-plugin-sdk": "6.12.0",
55+
"@sentry-internal/eslint-config-sdk": "6.17.9",
56+
"@sentry-internal/eslint-plugin-sdk": "6.17.9",
5757
"@sentry/typescript": "^5.20.0",
5858
"@types/jest": "^26.0.15",
5959
"@types/react": "^16.9.49",

sample/yarn.lock

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4055,7 +4055,7 @@ arrify@^2.0.1:
40554055
resolved "https://registry.yarnpkg.com/arrify/-/arrify-2.0.1.tgz#c9655e9331e0abcd588d2a7cad7e9956f66701fa"
40564056
integrity sha512-3duEwti880xqi4eAMN8AyR4a0ByT90zoYdLlevfrvU43vb0YZwZVfxOgxWrLXXXpyugL0hNZc9G6BiB5B3nUug==
40574057

4058-
asap@~2.0.6:
4058+
asap@~2.0.3, asap@~2.0.6:
40594059
version "2.0.6"
40604060
resolved "https://registry.yarnpkg.com/asap/-/asap-2.0.6.tgz#e50347611d7e690943208bbdafebcbc2fb866d46"
40614061
integrity sha1-5QNHYR1+aQlDIIu9r+vLwvuGbUY=
@@ -9678,7 +9678,14 @@ progress@^2.0.0, progress@^2.0.1:
96789678
resolved "https://registry.yarnpkg.com/progress/-/progress-2.0.3.tgz#7e8cf8d8f5b8f239c1bc68beb4eb78567d572ef8"
96799679
integrity sha512-7PiHtLll5LdnKIMw100I+8xJXR5gW2QwWYkT6iJva0bXitZKa/XMrSbdmg3r2Xnaidz9Qumd0VPaMrZlF9V9sA==
96809680

9681-
promise@^7.1.1, promise@^8.0.3, promise@^8.1.0:
9681+
promise@^7.1.1:
9682+
version "7.3.1"
9683+
resolved "https://registry.yarnpkg.com/promise/-/promise-7.3.1.tgz#064b72602b18f90f29192b8b1bc418ffd1ebd3bf"
9684+
integrity sha512-nolQXZ/4L+bP/UGlkfaIujX9BKxGwmQ9OT4mOt5yvy8iK1h3wqTEJCijzGANTCCl9nWjY41juyAn2K3Q1hLLTg==
9685+
dependencies:
9686+
asap "~2.0.3"
9687+
9688+
promise@^8.0.3:
96829689
version "8.1.0"
96839690
resolved "https://registry.yarnpkg.com/promise/-/promise-8.1.0.tgz#697c25c3dfe7435dd79fcd58c38a135888eaf05e"
96849691
integrity sha512-W04AqnILOL/sPRXziNicCjSNRruLAuIHEOVBazepu0545DDNGYHz7ar9ZgZ1fMU8/MA4mVxp5rkBWRi6OXIy3Q==

src/js/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export {
88
Severity,
99
StackFrame,
1010
Stacktrace,
11-
Status,
11+
EventStatus,
1212
Thread,
1313
User,
1414
} from "@sentry/types";

src/js/integrations/reactnativeerrorhandlers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export class ReactNativeErrorHandlers implements Integration {
7676
* - The package resolution fix no longer works with 0.67 on iOS Hermes.
7777
*/
7878
private _polyfillPromise(): void {
79-
/* eslint-disable import/no-extraneous-dependencies,@typescript-eslint/no-var-requires*/
79+
/* eslint-disable import/no-extraneous-dependencies,@typescript-eslint/no-var-requires */
8080
const {
8181
polyfillGlobal,
8282
} = require("react-native/Libraries/Utilities/PolyfillFunctions");

src/js/tracing/utils.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
1-
import {
2-
IdleTransaction,
3-
Span,
4-
SpanStatus,
5-
Transaction,
6-
} from "@sentry/tracing";
1+
import { IdleTransaction, Span, Transaction } from "@sentry/tracing";
72
import { TransactionContext } from "@sentry/types";
83
import { timestampInSeconds } from "@sentry/utils";
94

@@ -48,7 +43,7 @@ export function adjustTransactionDuration(
4843
const isOutdatedTransaction =
4944
endTimestamp && (diff > secToMs(maxDuration) || diff < 0);
5045
if (isOutdatedTransaction) {
51-
transaction.setStatus(SpanStatus.DeadlineExceeded);
46+
transaction.setStatus("deadline_exceeded");
5247
transaction.setTag("maxTransactionDurationExceeded", "true");
5348
}
5449
}

src/js/transports/native.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,17 @@
11
import { Event, Response, Transport } from "@sentry/types";
2-
import { PromiseBuffer, SentryError } from "@sentry/utils";
2+
import { makePromiseBuffer, PromiseBuffer } from "@sentry/utils";
33

44
import { NATIVE } from "../wrapper";
55

66
/** Native Transport class implementation */
77
export class NativeTransport implements Transport {
88
/** A simple buffer holding all requests. */
9-
protected readonly _buffer: PromiseBuffer<Response> = new PromiseBuffer(30);
9+
protected readonly _buffer: PromiseBuffer<Response> = makePromiseBuffer(30);
1010

1111
/**
1212
* @inheritDoc
1313
*/
1414
public sendEvent(event: Event): PromiseLike<Response> {
15-
if (!this._buffer.isReady()) {
16-
return Promise.reject(
17-
new SentryError("Not adding Promise due to buffer limit reached.")
18-
);
19-
}
2015
return this._buffer.add(() => NATIVE.sendEvent(event));
2116
}
2217

src/js/wrapper.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {
55
Package,
66
Response,
77
Severity,
8-
Status,
98
User,
109
} from "@sentry/types";
1110
import { logger, SentryError } from "@sentry/utils";
@@ -74,7 +73,7 @@ export const NATIVE: SentryNativeWrapper = {
7473
if (!this.enableNative) {
7574
return {
7675
reason: `Event was skipped as native SDK is not enabled.`,
77-
status: Status.Skipped,
76+
status: "skipped",
7877
};
7978
}
8079

@@ -84,6 +83,9 @@ export const NATIVE: SentryNativeWrapper = {
8483

8584
const event = this._processLevels(_event);
8685

86+
// Delete this metadata as this should not be sent to Sentry.
87+
delete event.sdkProcessingMetadata;
88+
8789
const header = {
8890
event_id: event.event_id,
8991
sdk: event.sdk,
@@ -156,12 +158,12 @@ export const NATIVE: SentryNativeWrapper = {
156158

157159
if (envelopeWasSent) {
158160
return {
159-
status: Status.Success,
161+
status: "success",
160162
};
161163
}
162164

163165
return {
164-
status: Status.Failed,
166+
status: "failed",
165167
};
166168
},
167169

test/backend.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ describe("Tests ReactNativeBackend", () => {
5555
dsn: "not a dsn",
5656
enableNative: true,
5757
});
58-
} catch (e) {
59-
expect(e.message).toBe("Invalid Dsn");
58+
} catch (e: any) {
59+
expect(e.message).toBe("Invalid Sentry Dsn: not a dsn");
6060
}
6161
});
6262

test/tracing/reactnativetracing.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,9 @@ describe("ReactNativeTracing", () => {
254254
const spanRecorder = routeTransaction.spanRecorder;
255255
expect(spanRecorder).toBeDefined();
256256
if (spanRecorder) {
257-
expect(spanRecorder.spans.length).toBe(2);
257+
expect(spanRecorder.spans.length).toBeGreaterThan(1);
258258

259-
const span = spanRecorder.spans[1];
259+
const span = spanRecorder.spans[spanRecorder.spans.length - 1];
260260

261261
expect(span.op).toBe("app.start.cold");
262262
expect(span.description).toBe("Cold App Start");
@@ -324,9 +324,9 @@ describe("ReactNativeTracing", () => {
324324
const spanRecorder = routeTransaction.spanRecorder;
325325
expect(spanRecorder).toBeDefined();
326326
if (spanRecorder) {
327-
expect(spanRecorder.spans.length).toBe(2);
327+
expect(spanRecorder.spans.length).toBeGreaterThan(1);
328328

329-
const span = spanRecorder.spans[1];
329+
const span = spanRecorder.spans[spanRecorder.spans.length - 1];
330330

331331
expect(span.op).toBe("app.start.warm");
332332
expect(span.description).toBe("Warm App Start");
@@ -392,7 +392,7 @@ describe("ReactNativeTracing", () => {
392392
const spanRecorder = routeTransaction.spanRecorder;
393393
expect(spanRecorder).toBeDefined();
394394
if (spanRecorder) {
395-
expect(spanRecorder.spans.length).toBe(1);
395+
expect(spanRecorder.spans.length).toBe(2);
396396
}
397397

398398
done();

0 commit comments

Comments
 (0)