Skip to content

Commit 12ff6ad

Browse files
committed
Fix ErrorListener not capturing events when Hub is not instantiated yet
1 parent cfece50 commit 12ff6ad

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

src/EventListener/ErrorListener.php

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,25 @@
22

33
namespace Sentry\SentryBundle\EventListener;
44

5+
use Sentry\State\HubInterface;
56
use Symfony\Component\Console\Event\ConsoleErrorEvent;
67
use Symfony\Component\Console\Event\ConsoleExceptionEvent;
78
use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;
89

910
final class ErrorListener
1011
{
12+
/** @var HubInterface */
13+
private $hub;
14+
15+
/**
16+
* ErrorListener constructor.
17+
* @param HubInterface $hub
18+
*/
19+
public function __construct(HubInterface $hub)
20+
{
21+
$this->hub = $hub; // not used, needed to trigger instantiation
22+
}
23+
1124
public function onKernelException(GetResponseForExceptionEvent $event): void
1225
{
1326
\Sentry\captureException($event->getException());

src/Resources/config/services.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
</service>
3232

3333
<service id="Sentry\SentryBundle\EventListener\ErrorListener" class="Sentry\SentryBundle\EventListener\ErrorListener" public="false">
34+
<argument type="service" id="Sentry\State\HubInterface" />
3435
<tag name="kernel.event_listener" event="kernel.exception" method="onKernelException" priority="%sentry.listener_priorities.request_error%" />
3536
<!-- The following tag is done manually in PHP for BC with Symfony < 3.3 -->
3637
<!-- <tag name="kernel.event_listener" event="console.error" method="onConsoleError" priority="%sentry.listener_priorities.console_error%" />-->

0 commit comments

Comments
 (0)