Skip to content

Commit 19c3410

Browse files
committed
Fix test; remove duplicated test
1 parent ce42bb8 commit 19c3410

File tree

1 file changed

+3
-37
lines changed

1 file changed

+3
-37
lines changed

test/DependencyInjection/SentryExtensionTest.php

Lines changed: 3 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -120,19 +120,18 @@ public function testErrorTypesAreParsed(): void
120120
/**
121121
* @dataProvider emptyDsnValueProvider
122122
*/
123-
public function test_that_it_ignores_empty_dsn_value($emptyDsn)
123+
public function test_that_it_ignores_empty_dsn_value($emptyDsn): void
124124
{
125-
$this->markTestIncomplete();
126125
$container = $this->getContainer(
127126
[
128127
'dsn' => $emptyDsn,
129128
]
130129
);
131130

132-
$this->assertNull($container->getParameter('sentry.dsn'));
131+
$this->assertNull($this->getOptionsFrom($container)->getDsn());
133132
}
134133

135-
public function emptyDsnValueProvider()
134+
public function emptyDsnValueProvider(): array
136135
{
137136
return [
138137
[null],
@@ -142,39 +141,6 @@ public function emptyDsnValueProvider()
142141
];
143142
}
144143

145-
public function test_that_it_has_proper_event_listener_tags_for_exception_listener()
146-
{
147-
$this->markTestIncomplete();
148-
$containerBuilder = new ContainerBuilder();
149-
$extension = new SentryExtension();
150-
$extension->load([], $containerBuilder);
151-
152-
$definition = $containerBuilder->getDefinition('sentry.exception_listener');
153-
$tags = $definition->getTag('kernel.event_listener');
154-
155-
$this->assertSame(
156-
[
157-
[
158-
'event' => 'kernel.request',
159-
'method' => 'onKernelRequest',
160-
'priority' => '%sentry.listener_priorities.request%',
161-
],
162-
[
163-
'event' => 'kernel.exception',
164-
'method' => 'onKernelException',
165-
'priority' => '%sentry.listener_priorities.kernel_exception%',
166-
],
167-
['event' => 'console.command', 'method' => 'onConsoleCommand'],
168-
[
169-
'event' => 'console.error',
170-
'method' => 'onConsoleError',
171-
'priority' => '%sentry.listener_priorities.console_exception%',
172-
],
173-
],
174-
$tags
175-
);
176-
}
177-
178144
private function getContainer(array $configuration = []): Container
179145
{
180146
$containerBuilder = new ContainerBuilder();

0 commit comments

Comments
 (0)