Skip to content

Commit 1d56a6d

Browse files
authored
ref: Use _route as the transaction name (#692)
1 parent 06727d7 commit 1d56a6d

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/EventListener/TracingRequestListener.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,16 @@ public function handleKernelRequestEvent(RequestEvent $event): void
4242
$request->headers->get('baggage', '')
4343
);
4444
$context->setOp('http.server');
45-
$context->setName(sprintf('%s %s%s%s', $request->getMethod(), $request->getSchemeAndHttpHost(), $request->getBaseUrl(), $request->getPathInfo()));
46-
$context->setSource(TransactionSource::url());
45+
46+
$routeName = $request->attributes->get('_route');
47+
if (null !== $routeName && \is_string($routeName)) {
48+
$context->setName(sprintf('%s %s', $request->getMethod(), $routeName));
49+
$context->setSource(TransactionSource::route());
50+
} else {
51+
$context->setName(sprintf('%s %s%s%s', $request->getMethod(), $request->getSchemeAndHttpHost(), $request->getBaseUrl(), $request->getPathInfo()));
52+
$context->setSource(TransactionSource::url());
53+
}
54+
4755
$context->setStartTimestamp($requestStartTime);
4856
$context->setTags($this->getTags($request));
4957

tests/EventListener/TracingRequestListenerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,8 @@ public function handleKernelRequestEventDataProvider(): \Generator
217217
$request->attributes->set('_route', 'app_homepage');
218218

219219
$transactionContext = new TransactionContext();
220-
$transactionContext->setName('GET http://www.example.com/path');
221-
$transactionContext->setSource(TransactionSource::url());
220+
$transactionContext->setName('GET app_homepage');
221+
$transactionContext->setSource(TransactionSource::route());
222222
$transactionContext->setOp('http.server');
223223
$transactionContext->setStartTimestamp(1613493597.010275);
224224
$transactionContext->setTags([

0 commit comments

Comments
 (0)