Add more E2E tests

Author: Jean85

test/End2End/App/Controller/MainController.php

@@ -2,12 +2,50 @@
 
 namespace Sentry\SentryBundle\Test\End2End\App\Controller;
 
+use Sentry\State\HubInterface;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\HttpKernelInterface;
 
 class MainController
 {
+    /** @var HubInterface */
+    private $sentry;
+
+    /** @var RequestStack */
+    private $requestStack;
+
+    /** @var HttpKernelInterface */
+    private $kernel;
+
+    public function __construct(HubInterface $sentry, RequestStack $requestStack, HttpKernelInterface $kernel)
+    {
+        $this->sentry = $sentry;
+        $this->requestStack = $requestStack;
+        $this->kernel = $kernel;
+    }
+
     public function exception(): Response
     {
         throw new \RuntimeException('This is an intentional error');
     }
+
+    public function index(): Response
+    {
+        $this->sentry->captureMessage('Hello there');
+
+        return new Response('Hello there');
+    }
+
+    public function subrequest(): Response
+    {
+        $request = $this->requestStack->getCurrentRequest();
+        assert($request instanceof Request);
+        $path['_controller'] = __CLASS__ . '::index';
+
+        $subRequest = $request->duplicate([], null, $path);
+
+        return $this->kernel->handle($subRequest, HttpKernelInterface::SUB_REQUEST);
+    }
 }

test/End2End/App/config.yml

@@ -8,6 +8,11 @@ services:
     alias: Sentry\State\HubInterface
     public: true
 
+  Sentry\SentryBundle\Test\End2End\App\Controller\MainController:
+    autowire: true
+    tags:
+      - controller.service_arguments
+
 monolog:
   handlers:
     main:

test/End2End/App/routing.yml

@@ -1,3 +1,15 @@
 exception:
   path:  /exception
   defaults: { _controller: '\Sentry\SentryBundle\Test\End2End\App\Controller\MainController::exception' }
+
+200:
+  path:  /200
+  defaults: { _controller: '\Sentry\SentryBundle\Test\End2End\App\Controller\MainController::index' }
+
+secured200:
+  path:  /secured/200
+  defaults: { _controller: '\Sentry\SentryBundle\Test\End2End\App\Controller\MainController::index' }
+
+subrequest:
+  path:  /subrequest
+  defaults: { _controller: '\Sentry\SentryBundle\Test\End2End\App\Controller\MainController::subrequest' }

test/End2End/End2EndTest.php

@@ -26,6 +26,48 @@ protected static function getKernelClass(): string
         return Kernel::class;
     }
 
+    public function testGet200(): void
+    {
+        $client = static::createClient(['debug' => false]);
+
+        $client->request('GET', '/200');
+
+        $response = $client->getResponse();
+
+        $this->assertInstanceOf(Response::class, $response);
+        $this->assertSame(200, $response->getStatusCode());
+
+        $this->assertLastEventIdIsNotNull($client);
+    }
+
+    public function testGet200BehindFirewall(): void
+    {
+        $client = static::createClient(['debug' => false]);
+
+        $client->request('GET', '/secured/200');
+
+        $response = $client->getResponse();
+
+        $this->assertInstanceOf(Response::class, $response);
+        $this->assertSame(200, $response->getStatusCode());
+
+        $this->assertLastEventIdIsNotNull($client);
+    }
+
+    public function testGet200WithSubrequest(): void
+    {
+        $client = static::createClient(['debug' => false]);
+
+        $client->request('GET', '/subrequest');
+
+        $response = $client->getResponse();
+
+        $this->assertInstanceOf(Response::class, $response);
+        $this->assertSame(200, $response->getStatusCode());
+
+        $this->assertLastEventIdIsNotNull($client);
+    }
+
     public function testGet404(): void
     {
         $client = static::createClient(['debug' => false]);