Skip to content

Commit 3ca5cab

Browse files
authored
Fix missing sentry.tracing.enabled parameter in the service container (#478)
1 parent 8e2fbda commit 3ca5cab

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/DependencyInjection/SentryExtension.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,10 @@ private function registerMessengerListenerConfiguration(ContainerBuilder $contai
165165
/**
166166
* @param array<string, mixed> $config
167167
*/
168-
private function registerTracingConfiguration(ContainerBuilder $container, $config): void
168+
private function registerTracingConfiguration(ContainerBuilder $container, array $config): void
169169
{
170+
$container->setParameter('sentry.tracing.enabled', $config['enabled']);
171+
170172
if (!$this->isConfigEnabled($container, $config)) {
171173
$container->removeDefinition(TracingRequestListener::class);
172174
$container->removeDefinition(TracingSubRequestListener::class);

tests/DependencyInjection/SentryExtensionTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,7 @@ public function testInstrumentationIsDisabledWhenTracingIsDisabled(): void
316316
$this->assertFalse($container->hasDefinition(TracingDriverMiddleware::class));
317317
$this->assertFalse($container->hasDefinition(ConnectionConfigurator::class));
318318
$this->assertFalse($container->hasDefinition(TwigTracingExtension::class));
319+
$this->assertFalse($container->getParameter('sentry.tracing.enabled'));
319320
$this->assertEmpty($container->getParameter('sentry.tracing.dbal.connections'));
320321
}
321322

0 commit comments

Comments
 (0)