Skip to content

Commit 6421d85

Browse files
rjd22ste93cry
authored andcommitted
Improve symfony response times when tracing is enabled
Improve symfony response times when tracing is enabled by sending the tracing results on kernel terminate. Kernel terminate happens after rendering and sending the response to the client so clients won't notice any delay.
1 parent e0ce070 commit 6421d85

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/EventListener/TracingRequestListener.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
use Sentry\Tracing\Transaction;
88
use Sentry\Tracing\TransactionContext;
99
use Symfony\Component\HttpFoundation\Request;
10-
use Symfony\Component\HttpKernel\Event\FinishRequestEvent;
10+
use Symfony\Component\HttpKernel\Event\TerminateEvent;
1111

1212
/**
1313
* This event listener acts on the master requests and starts a transaction
@@ -44,11 +44,11 @@ public function handleKernelRequestEvent(RequestListenerRequestEvent $event): vo
4444

4545
/**
4646
* This method is called for each request handled by the framework and
47-
* ends the tracing.
47+
* ends the tracing on terminate after the client received the response.
4848
*
49-
* @param FinishRequestEvent $event The event
49+
* @param TerminateEvent $event The event
5050
*/
51-
public function handleKernelFinishRequestEvent(FinishRequestEvent $event): void
51+
public function handleKernelTerminateEvent(TerminateEvent $event): void
5252
{
5353
if (!$event->isMasterRequest()) {
5454
return;

src/Resources/config/services.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
<argument type="service" id="Sentry\State\HubInterface" />
5959

6060
<tag name="kernel.event_listener" event="kernel.request" method="handleKernelRequestEvent" priority="4" />
61-
<tag name="kernel.event_listener" event="kernel.finish_request" method="handleKernelFinishRequestEvent" priority="5" />
6261
<tag name="kernel.event_listener" event="kernel.response" method="handleKernelResponseEvent" priority="15" />
62+
<tag name="kernel.event_listener" event="kernel.terminate" method="handleKernelTerminateEvent" priority="5" />
6363
</service>
6464

6565
<service id="Sentry\SentryBundle\EventListener\TracingSubRequestListener" class="Sentry\SentryBundle\EventListener\TracingSubRequestListener">

0 commit comments

Comments
 (0)