Skip to content

Commit 7cd655b

Browse files
committed
Fix more tests
1 parent 0c6cea7 commit 7cd655b

File tree

2 files changed

+23
-8
lines changed

2 files changed

+23
-8
lines changed

test/EventListener/SubRequestListenerTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function testOnKernelRequestWithSubRequest(): void
4848
$listener->onKernelRequest($subRequestEvent);
4949
}
5050

51-
public function testOnKernelFinishRequestWithMasterRequest(): void
51+
public function testonFinishRequestWithMasterRequest(): void
5252
{
5353
$listener = new SubRequestListener();
5454

@@ -57,10 +57,10 @@ public function testOnKernelFinishRequestWithMasterRequest(): void
5757
$this->currentHub->popScope()
5858
->shouldNotBeCalled();
5959

60-
$listener->onKernelFinishRequest($masterRequestEvent);
60+
$listener->onFinishRequest($masterRequestEvent);
6161
}
6262

63-
public function testOnKernelFinishRequestWithSubRequest(): void
63+
public function testonFinishRequestWithSubRequest(): void
6464
{
6565
$listener = new SubRequestListener();
6666

@@ -70,7 +70,7 @@ public function testOnKernelFinishRequestWithSubRequest(): void
7070
->shouldBeCalledTimes(1)
7171
->willReturn(true);
7272

73-
$listener->onKernelFinishRequest($subRequestEvent);
73+
$listener->onFinishRequest($subRequestEvent);
7474
}
7575

7676
private function createFinishRequestEvent(int $type): FinishRequestEvent

test/SentryBundleTest.php

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
use Symfony\Component\DependencyInjection\ContainerBuilder;
2121
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
2222
use Symfony\Component\HttpKernel\Event\ExceptionEvent;
23+
use Symfony\Component\HttpKernel\Event\RequestEvent;
2324
use Symfony\Component\HttpKernel\KernelEvents;
2425

2526
class SentryBundleTest extends TestCase
@@ -49,16 +50,24 @@ public function testContainerHasRequestListenerConfiguredCorrectly(): void
4950

5051
$consoleListener = $container->getDefinition(RequestListener::class);
5152

53+
if (class_exists(RequestEvent::class)) {
54+
$requestMethod = 'onRequest';
55+
$controllerMethod = 'onController';
56+
} else {
57+
$requestMethod = 'onKernelRequest';
58+
$controllerMethod = 'onKernelController';
59+
}
60+
5261
$expectedTag = [
5362
'kernel.event_listener' => [
5463
[
5564
'event' => KernelEvents::REQUEST,
56-
'method' => 'onKernelRequest',
65+
'method' => $requestMethod,
5766
'priority' => '%sentry.listener_priorities.request%',
5867
],
5968
[
6069
'event' => KernelEvents::CONTROLLER,
61-
'method' => 'onKernelController',
70+
'method' => $controllerMethod,
6271
'priority' => '%sentry.listener_priorities.request%',
6372
],
6473
],
@@ -73,16 +82,22 @@ public function testContainerHasSubRequestListenerConfiguredCorrectly(): void
7382

7483
$consoleListener = $container->getDefinition(SubRequestListener::class);
7584

85+
if (class_exists(RequestEvent::class)) {
86+
$requestMethod = 'onRequest';
87+
} else {
88+
$requestMethod = 'onKernelRequest';
89+
}
90+
7691
$expectedTag = [
7792
'kernel.event_listener' => [
7893
[
7994
'event' => KernelEvents::REQUEST,
80-
'method' => 'onKernelRequest',
95+
'method' => $requestMethod,
8196
'priority' => '%sentry.listener_priorities.sub_request%',
8297
],
8398
[
8499
'event' => KernelEvents::FINISH_REQUEST,
85-
'method' => 'onKernelFinishRequest',
100+
'method' => 'onFinishRequest',
86101
'priority' => '%sentry.listener_priorities.sub_request%',
87102
],
88103
],

0 commit comments

Comments
 (0)