Add missing unit tests for some code paths of the TraceableCacheAdapterTrait trait

Author: ste93cry

phpstan-baseline.neon

@@ -202,22 +202,22 @@ parameters:
 
 		-
 			message: "#^Call to an undefined method TCacheAdapter of Symfony\\\\Component\\\\Cache\\\\Adapter\\\\AdapterInterface\\:\\:delete\\(\\)\\.$#"
-			count: 1
+			count: 2
 			path: tests/Tracing/Cache/AbstractTraceableCacheAdapterTest.php
 
 		-
 			message: "#^Call to an undefined method TCacheAdapter of Symfony\\\\Component\\\\Cache\\\\Adapter\\\\AdapterInterface\\:\\:get\\(\\)\\.$#"
-			count: 1
+			count: 2
 			path: tests/Tracing/Cache/AbstractTraceableCacheAdapterTest.php
 
 		-
 			message: "#^Call to an undefined method TCacheAdapter of Symfony\\\\Component\\\\Cache\\\\Adapter\\\\AdapterInterface\\:\\:prune\\(\\)\\.$#"
-			count: 1
+			count: 2
 			path: tests/Tracing/Cache/AbstractTraceableCacheAdapterTest.php
 
 		-
 			message: "#^Call to an undefined method TCacheAdapter of Symfony\\\\Component\\\\Cache\\\\Adapter\\\\AdapterInterface\\:\\:reset\\(\\)\\.$#"
-			count: 1
+			count: 2
 			path: tests/Tracing/Cache/AbstractTraceableCacheAdapterTest.php
 
 		-

src/Tracing/Cache/TraceableCacheAdapterTrait.php

@@ -71,7 +71,7 @@ public function get(string $key, callable $callback, float $beta = null, array &
     {
         return $this->traceFunction('cache.get_item', function () use ($key, $callback, $beta, &$metadata) {
             if (!$this->decoratedAdapter instanceof CacheInterface) {
-                throw new \BadMethodCallException(sprintf('The %s() method is not supported on an adapter that does not implement the "%s" interface.', __FUNCTION__, CacheInterface::class));
+                throw new \BadMethodCallException(sprintf('The %s::get() method is not supported because the decorated adapter does not implement the "%s" interface.', self::class, CacheInterface::class));
             }
 
             return $this->decoratedAdapter->get($key, $callback, $beta, $metadata);
@@ -85,7 +85,7 @@ public function delete(string $key): bool
     {
         return $this->traceFunction('cache.delete_item', function () use ($key) {
             if (!$this->decoratedAdapter instanceof CacheInterface) {
-                throw new \BadMethodCallException(sprintf('The %s() method is not supported on an adapter that does not implement the "%s" interface.', __FUNCTION__, CacheInterface::class));
+                throw new \BadMethodCallException(sprintf('The %s::delete() method is not supported because the decorated adapter does not implement the "%s" interface.', self::class, CacheInterface::class));
             }
 
             return $this->decoratedAdapter->delete($key);
@@ -159,7 +159,7 @@ public function prune(): bool
     {
         return $this->traceFunction('cache.prune', function (): bool {
             if (!$this->decoratedAdapter instanceof PruneableInterface) {
-                throw new \BadMethodCallException(sprintf('The %s() method is not supported on an adapter that does not implement the "%s" interface.', __FUNCTION__, PruneableInterface::class));
+                throw new \BadMethodCallException(sprintf('The %s::prune() method is not supported because the decorated adapter does not implement the "%s" interface.', self::class, PruneableInterface::class));
             }
 
             return $this->decoratedAdapter->prune();
@@ -172,7 +172,7 @@ public function prune(): bool
     public function reset(): void
     {
         if (!$this->decoratedAdapter instanceof ResettableInterface) {
-            throw new \BadMethodCallException(sprintf('The %s() method is not supported on an adapter that does not implement the "%s" interface.', __FUNCTION__, ResettableInterface::class));
+            throw new \BadMethodCallException(sprintf('The %s::reset() method is not supported because the decorated adapter does not implement the "%s" interface.', self::class, ResettableInterface::class));
         }
 
         $this->decoratedAdapter->reset();

tests/Tracing/Cache/AbstractTraceableCacheAdapterTest.php

@@ -146,6 +146,16 @@ public function testGet(): void
         $this->assertNotNull($spans[1]->getEndTimestamp());
     }
 
+    public function testGetThrowsExceptionIfDecoratedAdapterDoesNotImplementTheCacheInterface(): void
+    {
+        $adapter = $this->createCacheAdapter($this->createMock(static::getAdapterClassFqcn()));
+
+        $this->expectException(\BadMethodCallException::class);
+        $this->expectExceptionMessage(sprintf('The %s::get() method is not supported because the decorated adapter does not implement the "Symfony\\Contracts\\Cache\\CacheInterface" interface.', \get_class($adapter)));
+
+        $adapter->get('foo', static function () {});
+    }
+
     public function testDelete(): void
     {
         $transaction = new Transaction(new TransactionContext(), $this->hub);
@@ -172,6 +182,16 @@ public function testDelete(): void
         $this->assertNotNull($spans[1]->getEndTimestamp());
     }
 
+    public function testDeleteThrowsExceptionIfDecoratedAdapterDoesNotImplementTheCacheInterface(): void
+    {
+        $adapter = $this->createCacheAdapter($this->createMock(static::getAdapterClassFqcn()));
+
+        $this->expectException(\BadMethodCallException::class);
+        $this->expectExceptionMessage(sprintf('The %s::delete() method is not supported because the decorated adapter does not implement the "Symfony\\Contracts\\Cache\\CacheInterface" interface.', \get_class($adapter)));
+
+        $adapter->delete('foo');
+    }
+
     public function testHasItem(): void
     {
         $transaction = new Transaction(new TransactionContext(), $this->hub);
@@ -354,6 +374,16 @@ public function testPrune(): void
         $this->assertNotNull($spans[1]->getEndTimestamp());
     }
 
+    public function testPruneThrowsExceptionIfDecoratedAdapterIsNotPruneable(): void
+    {
+        $adapter = $this->createCacheAdapter($this->createMock(static::getAdapterClassFqcn()));
+
+        $this->expectException(\BadMethodCallException::class);
+        $this->expectExceptionMessage(sprintf('The %s::prune() method is not supported because the decorated adapter does not implement the "Symfony\\Component\\Cache\\PruneableInterface" interface.', \get_class($adapter)));
+
+        $adapter->prune();
+    }
+
     public function testReset(): void
     {
         $decoratedAdapter = $this->createMock(ResettableCacheAdapterInterface::class);
@@ -364,6 +394,16 @@ public function testReset(): void
         $adapter->reset();
     }
 
+    public function testResetThrowsExceptionIfDecoratedAdapterIsNotResettable(): void
+    {
+        $adapter = $this->createCacheAdapter($this->createMock(static::getAdapterClassFqcn()));
+
+        $this->expectException(\BadMethodCallException::class);
+        $this->expectExceptionMessage(sprintf('The %s::reset() method is not supported because the decorated adapter does not implement the "Symfony\\Component\\Cache\\ResettableInterface" interface.', \get_class($adapter)));
+
+        $adapter->reset();
+    }
+
     private static function isCachePackageInstalled(): bool
     {
         return interface_exists(BaseCacheInterface::class);