Map the max_request_body_size option in Configuration

Author: Jean85

src/DependencyInjection/Configuration.php

@@ -93,6 +93,15 @@ public function getConfigTreeBuilder(): TreeBuilder
             })
             ->thenInvalid('Expecting service reference, got "%s"');
         $optionsChildNodes->scalarNode('logger');
+        if ($this->maxRequestBodySizeIsSupported()) {
+            $optionsChildNodes->enumNode('max_request_body_size')
+                ->values([
+                    'none',
+                    'small',
+                    'medium',
+                    'always',
+                ]);
+        }
         $optionsChildNodes->integerNode('max_breadcrumbs')
             ->min(1);
         $optionsChildNodes->integerNode('max_value_length')
@@ -170,9 +179,19 @@ private function isNotAValidCallback(): \Closure
     }
 
     private function classSerializersAreSupported(): bool
+    {
+        return $this->optionIsSupported('class_serializers', []);
+    }
+
+    private function maxRequestBodySizeIsSupported(): bool
+    {
+        return $this->optionIsSupported('max_request_body_size', 'none');
+    }
+
+    private function optionIsSupported(string $name, $defaultValue): bool
     {
         try {
-            new Options(['class_serializers' => []]);
+            new Options([$name => $defaultValue]);
 
             return true;
         } catch (\Throwable $throwable) {

test/BaseTestCase.php

@@ -4,29 +4,42 @@
 
 use PHPUnit\Framework\TestCase;
 use Sentry\Options;
-use Sentry\SentryBundle\Test\DependencyInjection\ConfigurationTest;
 
 abstract class BaseTestCase extends TestCase
 {
-    public const SUPPORTED_SENTRY_OPTIONS_COUNT = 23;
-
     protected function classSerializersAreSupported(): bool
     {
-        try {
-            new Options(['class_serializers' => []]);
+        return $this->optionIsSupported('class_serializers', []);
+    }
 
-            return true;
-        } catch (\Throwable $throwable) {
-            return false;
-        }
+    protected function maxRequestBodySizeIsSupported(): bool
+    {
+        return $this->optionIsSupported('max_request_body_size', 'none');
     }
 
     protected function getSupportedOptionsCount(): int
     {
+        $count = 23;
+
         if ($this->classSerializersAreSupported()) {
-            return ConfigurationTest::SUPPORTED_SENTRY_OPTIONS_COUNT + 1;
+            ++$count;
+        }
+
+        if ($this->maxRequestBodySizeIsSupported()) {
+            ++$count;
         }
 
-        return ConfigurationTest::SUPPORTED_SENTRY_OPTIONS_COUNT;
+        return $count;
+    }
+
+    private function optionIsSupported(string $name, $defaultValue): bool
+    {
+        try {
+            new Options([$name => $defaultValue]);
+
+            return true;
+        } catch (\Throwable $throwable) {
+            return false;
+        }
     }
 }

test/DependencyInjection/ConfigurationTest.php

@@ -112,6 +112,10 @@ public function optionValuesProvider(): array
             ['excluded_exceptions', [\Throwable::class]],
             ['logger', 'some-logger'],
             ['max_breadcrumbs', 15],
+            ['max_request_body_size', 'none'],
+            ['max_request_body_size', 'small'],
+            ['max_request_body_size', 'medium'],
+            ['max_request_body_size', 'always'],
             ['max_value_length', 1000],
             ['prefixes', ['some-string']],
             ['project_root', '/some/dir'],
@@ -174,6 +178,8 @@ public function invalidValuesProvider(): array
             ['integrations', [1]],
             ['integrations', 'a string'],
             ['logger', []],
+            ['max_request_body_size', null],
+            ['max_request_body_size', 'invalid'],
             ['max_breadcrumbs', -1],
             ['max_breadcrumbs', 'string'],
             ['max_value_length', -1],