Skip to content

Commit b0a5ade

Browse files
committed
Fix test (and bug) in listener registration
1 parent cd15792 commit b0a5ade

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/DependencyInjection/SentryExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ private function tagExceptionListener(ContainerBuilder $container): void
166166
$tagAttributes = [
167167
'event' => KernelEvents::EXCEPTION,
168168
'method' => $method,
169-
'priority' => '%sentry.listener_priorities.console_error%',
169+
'priority' => '%sentry.listener_priorities.request_error%',
170170
];
171171

172172
$listener->addTag('kernel.event_listener', $tagAttributes);

test/SentryBundleTest.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717
use Sentry\State\Hub;
1818
use Sentry\State\HubInterface;
1919
use Symfony\Component\Console\ConsoleEvents;
20+
use Symfony\Component\Console\Event\ConsoleErrorEvent;
2021
use Symfony\Component\DependencyInjection\ContainerBuilder;
2122
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
23+
use Symfony\Component\HttpKernel\Event\ExceptionEvent;
2224
use Symfony\Component\HttpKernel\Kernel;
2325
use Symfony\Component\HttpKernel\KernelEvents;
2426

@@ -97,17 +99,20 @@ public function testContainerHasErrorListenerConfiguredCorrectly(): void
9799

98100
$consoleListener = $container->getDefinition(ErrorListener::class);
99101

102+
$method = class_exists(ExceptionEvent::class)
103+
? 'onException'
104+
: 'onKernelException';
100105
$expectedTag = [
101106
'kernel.event_listener' => [
102107
[
103108
'event' => KernelEvents::EXCEPTION,
104-
'method' => 'onKernelException',
109+
'method' => $method,
105110
'priority' => '%sentry.listener_priorities.request_error%',
106111
],
107112
],
108113
];
109114

110-
if (class_exists('Symfony\Component\Console\Event\ConsoleErrorEvent')) {
115+
if (class_exists(ConsoleErrorEvent::class)) {
111116
$expectedTag['kernel.event_listener'][] = [
112117
'event' => ConsoleEvents::ERROR,
113118
'method' => 'onConsoleError',

0 commit comments

Comments
 (0)