Skip to content

Commit c6f52ec

Browse files
committed
fix: Update span ops
1 parent bf8e336 commit c6f52ec

File tree

6 files changed

+11
-2
lines changed

6 files changed

+11
-2
lines changed

phpstan.neon

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ parameters:
1010
- src/aliases.php
1111
excludePaths:
1212
- src/aliases.php
13+
- src/Tracing/Cache/TraceableCacheAdapterForV2.php
14+
- src/Tracing/Cache/TraceableTagAwareCacheAdapterForV2.php
1315
- src/Tracing/Doctrine/DBAL/TracingStatementForV2.php
1416
- src/Tracing/Doctrine/DBAL/TracingDriverForV2.php
1517
- tests/End2End/App

src/Tracing/Twig/TwigTracingExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function enter(Profile $profile): void
4848
}
4949

5050
$spanContext = new SpanContext();
51-
$spanContext->setOp('symfony.view');
51+
$spanContext->setOp('view.render');
5252
$spanContext->setDescription($this->getSpanDescription($profile));
5353

5454
$this->spans[$profile] = $transaction->startChild($spanContext);

tests/End2End/App/Kernel.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,10 @@ public function registerContainerConfiguration(LoaderInterface $loader): void
4444
$loader->load(__DIR__ . '/deprecations_for_5.yml');
4545
}
4646

47+
if (self::VERSION_ID >= 60000) {
48+
$loader->load(__DIR__ . '/deprecations_for_6.yml');
49+
}
50+
4751
if (interface_exists(MessageBusInterface::class) && self::VERSION_ID >= 40300) {
4852
$loader->load(__DIR__ . '/messenger.yml');
4953
}

tests/End2End/App/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
sentry:
2+
dsn: http://[email protected]/sentry/1
23
tracing:
34
enabled: true
45
options:
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
framework:
2+
http_method_override: false

tests/Tracing/Twig/TwigTracingExtensionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function testEnter(Profile $profile, string $spanDescription): void
5858

5959
$this->assertCount(2, $spans);
6060
$this->assertNull($spans[1]->getEndTimestamp());
61-
$this->assertSame('symfony.view', $spans[1]->getOp());
61+
$this->assertSame('view.render', $spans[1]->getOp());
6262
$this->assertSame($spanDescription, $spans[1]->getDescription());
6363
}
6464

0 commit comments

Comments
 (0)