Use method_exists to check for option support

Author: Jean85

phpstan.neon

@@ -6,6 +6,8 @@ parameters:
     ignoreErrors:
          - "/Call to function method_exists.. with 'Symfony.+' and 'getProjectDir' will always evaluate to false./"
          - "/Call to function method_exists.. with 'Symfony.+' and 'getRootNode' will always evaluate to false./"
+         - "/Call to function method_exists.. with 'Sentry..Options' and 'getClassSerializers' will always evaluate to false./"
+         - "/Call to function method_exists.. with 'Sentry..Options' and 'getMaxRequestBodySi...' will always evaluate to false./"
          - '/Parameter \$.+ of method Sentry\\SentryBundle\\EventListener\\ErrorListener::onConsoleException\(\) has invalid typehint type Symfony\\Component\\Console\\Event\\ConsoleExceptionEvent./'
          - '/Call to method getException\(\) on an unknown class Symfony\\Component\\Console\\Event\\ConsoleExceptionEvent./'
          - '/Access to undefined constant Symfony\\Component\\Console\\ConsoleEvents::EXCEPTION./'

src/DependencyInjection/Configuration.php

@@ -180,22 +180,11 @@ private function isNotAValidCallback(): \Closure
 
     private function classSerializersAreSupported(): bool
     {
-        return $this->optionIsSupported('class_serializers', []);
+        return method_exists(Options::class, 'getClassSerializers');
     }
 
     private function maxRequestBodySizeIsSupported(): bool
     {
-        return $this->optionIsSupported('max_request_body_size', 'none');
-    }
-
-    private function optionIsSupported(string $name, $defaultValue): bool
-    {
-        try {
-            new Options([$name => $defaultValue]);
-
-            return true;
-        } catch (\Throwable $throwable) {
-            return false;
-        }
+        return method_exists(Options::class, 'getMaxRequestBodySize');
     }
 }

test/BaseTestCase.php

@@ -9,12 +9,12 @@ abstract class BaseTestCase extends TestCase
 {
     protected function classSerializersAreSupported(): bool
     {
-        return $this->optionIsSupported('class_serializers', []);
+        return method_exists(Options::class, 'getClassSerializers');
     }
 
     protected function maxRequestBodySizeIsSupported(): bool
     {
-        return $this->optionIsSupported('max_request_body_size', 'none');
+        return method_exists(Options::class, 'getMaxRequestBodySize');
     }
 
     protected function getSupportedOptionsCount(): int
@@ -31,15 +31,4 @@ protected function getSupportedOptionsCount(): int
 
         return $count;
     }
-
-    private function optionIsSupported(string $name, $defaultValue): bool
-    {
-        try {
-            new Options([$name => $defaultValue]);
-
-            return true;
-        } catch (\Throwable $throwable) {
-            return false;
-        }
-    }
 }