Skip to content

Commit 072a4f9

Browse files
narsaynorathnarsaynorath
authored
feat(perf-issues): Replace sentence keys with snake case in backend (#47830)
Replaces usages of "Encoded Body Size", "Decoded Body Size", "Transfer Size" with their snake case counterparts. This is for standardizing with OTel formatting in SDKs. Motivating discussion: getsentry/sentry-javascript#7935 (comment)
1 parent 3b5ae71 commit 072a4f9

File tree

12 files changed

+129
-116
lines changed

12 files changed

+129
-116
lines changed

‎bin/load-mocks

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1054,9 +1054,9 @@ def create_mock_transactions(
10541054
"span_id": uuid4().hex[:16],
10551055
"hash": "858fea692d4d93e9",
10561056
"data": {
1057-
"Transfer Size": 1_000_000,
1058-
"Encoded Body Size": 1_000_000,
1059-
"Decoded Body Size": 1_000_000,
1057+
"http.transfer_size": 1_000_000,
1058+
"http.response_content_length": 1_000_000,
1059+
"http.decoded_response_content_length": 1_000_000,
10601060
},
10611061
},
10621062
]
@@ -1147,7 +1147,7 @@ def create_mock_transactions(
11471147
"parent_span_id": parent_span_id,
11481148
"span_id": uuid4().hex[:16],
11491149
"hash": "858fea692d4d93e8",
1150-
"data": {"Encoded Body Size": 1000001},
1150+
"data": {"http.response_content_length": 1000001},
11511151
}
11521152
]
11531153

‎fixtures/events/performance_problems/consecutive-http/consecutive-http-basic.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1381,9 +1381,9 @@
13811381
"parent_span_id": "90747d4310a2a358",
13821382
"trace_id": "dfbb4f07016a450791bf09d308d66af4",
13831383
"data": {
1384-
"Decoded Body Size": 2573190,
1385-
"Encoded Body Size": 527961,
1386-
"Transfer Size": 528261,
1384+
"http.decoded_response_content_length": 2573190,
1385+
"http.response_content_length": 527961,
1386+
"http.transfer_size": 528261,
13871387
"resource.render_blocking_status": "non-blocking"
13881388
},
13891389
"hash": "032ded07ff89c3b4"
@@ -1431,9 +1431,9 @@
14311431
"parent_span_id": "90747d4310a2a358",
14321432
"trace_id": "dfbb4f07016a450791bf09d308d66af4",
14331433
"data": {
1434-
"Decoded Body Size": 3870,
1435-
"Encoded Body Size": 3461,
1436-
"Transfer Size": 3761,
1434+
"http.decoded_response_content_length": 3870,
1435+
"http.response_content_length": 3461,
1436+
"http.transfer_size": 3761,
14371437
"resource.render_blocking_status": "non-blocking"
14381438
},
14391439
"hash": "35a63c8a85b1279a"
@@ -1448,9 +1448,9 @@
14481448
"parent_span_id": "90747d4310a2a358",
14491449
"trace_id": "dfbb4f07016a450791bf09d308d66af4",
14501450
"data": {
1451-
"Decoded Body Size": 492,
1452-
"Encoded Body Size": 492,
1453-
"Transfer Size": 792,
1451+
"http.decoded_response_content_length": 492,
1452+
"http.response_content_length": 492,
1453+
"http.transfer_size": 792,
14541454
"resource.render_blocking_status": "non-blocking"
14551455
},
14561456
"hash": "a2a63063e1bd6ed2"
@@ -1465,9 +1465,9 @@
14651465
"parent_span_id": "90747d4310a2a358",
14661466
"trace_id": "dfbb4f07016a450791bf09d308d66af4",
14671467
"data": {
1468-
"Decoded Body Size": 5347,
1469-
"Encoded Body Size": 5347,
1470-
"Transfer Size": 5647,
1468+
"http.decoded_response_content_length": 5347,
1469+
"http.response_content_length": 5347,
1470+
"http.transfer_size": 5647,
14711471
"resource.render_blocking_status": "non-blocking"
14721472
},
14731473
"hash": "03cf160ff9190e10"

‎fixtures/events/performance_problems/uncompressed-assets/uncompressed-script-asset.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@
5454
"parent_span_id": "a0c39078d1570b00",
5555
"trace_id": "0102834d0bf74d388ce0b1e15329f731",
5656
"data": {
57-
"Decoded Body Size": 3,
58-
"Encoded Body Size": 2,
59-
"Transfer Size": 3
57+
"http.decoded_response_content_length": 3,
58+
"http.response_content_length": 2,
59+
"http.transfer_size": 3
6060
},
6161
"hash": "b2978b51d54d9078"
6262
},
@@ -70,9 +70,9 @@
7070
"parent_span_id": "a0c39078d1570b00",
7171
"trace_id": "0102834d0bf74d388ce0b1e15329f731",
7272
"data": {
73-
"Decoded Body Size": 571733,
74-
"Encoded Body Size": 571733,
75-
"Transfer Size": 571833
73+
"http.decoded_response_content_length": 571733,
74+
"http.response_content_length": 571733,
75+
"http.transfer_size": 571833
7676
},
7777
"hash": "a2978b51d54d9079"
7878
}

‎src/sentry/data/samples/react-transaction.json

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1912,9 +1912,9 @@
19121912
"parent_span_id": "a7afa33e288a45c4",
19131913
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
19141914
"data": {
1915-
"Decoded Body Size": 1434,
1916-
"Encoded Body Size": 377,
1917-
"Transfer Size": 873,
1915+
"http.decoded_response_content_length": 1434,
1916+
"http.response_content_length": 377,
1917+
"http.transfer_size": 873,
19181918
"duration": 0.19784391574400753,
19191919
"offset": 1.987476914226067
19201920
}
@@ -1928,9 +1928,9 @@
19281928
"parent_span_id": "a7afa33e288a45c4",
19291929
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
19301930
"data": {
1931-
"Decoded Body Size": 2834,
1932-
"Encoded Body Size": 1031,
1933-
"Transfer Size": 1181,
1931+
"http.decoded_response_content_length": 2834,
1932+
"http.response_content_length": 1031,
1933+
"http.transfer_size": 1181,
19341934
"duration": 0.03448497280930315,
19351935
"offset": 2.185320829970075
19361936
}
@@ -1944,9 +1944,9 @@
19441944
"parent_span_id": "a7afa33e288a45c4",
19451945
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
19461946
"data": {
1947-
"Decoded Body Size": 393615,
1948-
"Encoded Body Size": 104822,
1949-
"Transfer Size": 105241,
1947+
"http.decoded_response_content_length": 393615,
1948+
"http.response_content_length": 104822,
1949+
"http.transfer_size": 105241,
19501950
"duration": 0.06483037331022606,
19511951
"offset": 2.219805802779378
19521952
}
@@ -1973,9 +1973,9 @@
19731973
"parent_span_id": "a7afa33e288a45c4",
19741974
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
19751975
"data": {
1976-
"Decoded Body Size": 14900,
1977-
"Encoded Body Size": 14900,
1978-
"Transfer Size": 15249,
1976+
"http.decoded_response_content_length": 14900,
1977+
"http.response_content_length": 14900,
1978+
"http.transfer_size": 15249,
19791979
"duration": 0.07117168916452873,
19801980
"offset": 2.3922796225243945
19811981
}
@@ -1989,9 +1989,9 @@
19891989
"parent_span_id": "a7afa33e288a45c4",
19901990
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
19911991
"data": {
1992-
"Decoded Body Size": 14904,
1993-
"Encoded Body Size": 14904,
1994-
"Transfer Size": 15018,
1992+
"http.decoded_response_content_length": 14904,
1993+
"http.response_content_length": 14904,
1994+
"http.transfer_size": 15018,
19951995
"duration": 0.01938506940816541,
19961996
"offset": 2.463451311688923
19971997
}
@@ -2031,9 +2031,9 @@
20312031
"parent_span_id": "a7afa33e288a45c4",
20322032
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
20332033
"data": {
2034-
"Decoded Body Size": 24838,
2035-
"Encoded Body Size": 3719,
2036-
"Transfer Size": 4007,
2034+
"http.decoded_response_content_length": 24838,
2035+
"http.response_content_length": 3719,
2036+
"http.transfer_size": 4007,
20372037
"duration": 0.13824814691353782,
20382038
"offset": 2.7785280575866445
20392039
}
@@ -2047,9 +2047,9 @@
20472047
"parent_span_id": "a7afa33e288a45c4",
20482048
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
20492049
"data": {
2050-
"Decoded Body Size": 0,
2051-
"Encoded Body Size": 0,
2052-
"Transfer Size": 0,
2050+
"http.decoded_response_content_length": 0,
2051+
"http.response_content_length": 0,
2052+
"http.transfer_size": 0,
20532053
"duration": 0.029537339013289896,
20542054
"offset": 2.916776204500182
20552055
}
@@ -2063,9 +2063,9 @@
20632063
"parent_span_id": "a7afa33e288a45c4",
20642064
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
20652065
"data": {
2066-
"Decoded Body Size": 0,
2067-
"Encoded Body Size": 0,
2068-
"Transfer Size": 0,
2066+
"http.decoded_response_content_length": 0,
2067+
"http.response_content_length": 0,
2068+
"http.transfer_size": 0,
20692069
"duration": 0.19305941897035148,
20702070
"offset": 2.946313543513472
20712071
}
@@ -2079,9 +2079,9 @@
20792079
"parent_span_id": "a7afa33e288a45c4",
20802080
"trace_id": "7eaab1c04557466d8588ddcb6bdd511d",
20812081
"data": {
2082-
"Decoded Body Size": 0,
2083-
"Encoded Body Size": 0,
2084-
"Transfer Size": 0,
2082+
"http.decoded_response_content_length": 0,
2083+
"http.response_content_length": 0,
2084+
"http.transfer_size": 0,
20852085
"duration": 0.8028300824075338,
20862086
"offset": 3.1393729624838236
20872087
}

‎src/sentry/data/samples/transaction-n-plus-one-api-call.json

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -691,9 +691,9 @@
691691
"parent_span_id": "829d17842d952371",
692692
"trace_id": "80972418b74940bda6977932055f7fcd",
693693
"data": {
694-
"Decoded Body Size": 48521,
695-
"Encoded Body Size": 9251,
696-
"Transfer Size": 9551
694+
"http.decoded_response_content_length": 48521,
695+
"http.response_content_length": 9251,
696+
"http.transfer_size": 9551
697697
},
698698
"hash": "1f1dd0897c16565b"
699699
},
@@ -707,9 +707,9 @@
707707
"parent_span_id": "829d17842d952371",
708708
"trace_id": "80972418b74940bda6977932055f7fcd",
709709
"data": {
710-
"Decoded Body Size": 4529244,
711-
"Encoded Body Size": 1103151,
712-
"Transfer Size": 1103451
710+
"http.decoded_response_content_length": 4529244,
711+
"http.response_content_length": 1103151,
712+
"http.transfer_size": 1103451
713713
},
714714
"hash": "1f058070477778b8"
715715
},
@@ -723,9 +723,9 @@
723723
"parent_span_id": "829d17842d952371",
724724
"trace_id": "80972418b74940bda6977932055f7fcd",
725725
"data": {
726-
"Decoded Body Size": 166604,
727-
"Encoded Body Size": 49443,
728-
"Transfer Size": 49743
726+
"http.decoded_response_content_length": 166604,
727+
"http.response_content_length": 49443,
728+
"http.transfer_size": 49743
729729
},
730730
"hash": "254c644cff8b3e09"
731731
},
@@ -739,9 +739,9 @@
739739
"parent_span_id": "829d17842d952371",
740740
"trace_id": "80972418b74940bda6977932055f7fcd",
741741
"data": {
742-
"Decoded Body Size": 1980965,
743-
"Encoded Body Size": 507607,
744-
"Transfer Size": 507907
742+
"http.decoded_response_content_length": 1980965,
743+
"http.response_content_length": 507607,
744+
"http.transfer_size": 507907
745745
},
746746
"hash": "779ec19f50f1ea39"
747747
},
@@ -754,7 +754,7 @@
754754
"span_id": "9d5b3c332aec7802",
755755
"parent_span_id": "829d17842d952371",
756756
"trace_id": "80972418b74940bda6977932055f7fcd",
757-
"data": {"Decoded Body Size": 296, "Encoded Body Size": 296, "Transfer Size": 596},
757+
"data": {"http.decoded_response_content_length": 296, "http.response_content_length": 296, "http.transfer_size": 596},
758758
"hash": "4f2043f50fc2f515"
759759
},
760760
{
@@ -766,7 +766,7 @@
766766
"span_id": "a92f3520fc053460",
767767
"parent_span_id": "829d17842d952371",
768768
"trace_id": "80972418b74940bda6977932055f7fcd",
769-
"data": {"Decoded Body Size": 76, "Encoded Body Size": 76, "Transfer Size": 376},
769+
"data": {"http.decoded_response_content_length": 76, "http.response_content_length": 76, "http.transfer_size": 376},
770770
"hash": "26d97630b7867f3e"
771771
},
772772
{
@@ -779,9 +779,9 @@
779779
"parent_span_id": "829d17842d952371",
780780
"trace_id": "80972418b74940bda6977932055f7fcd",
781781
"data": {
782-
"Decoded Body Size": 78104,
783-
"Encoded Body Size": 24604,
784-
"Transfer Size": 24904
782+
"http.decoded_response_content_length": 78104,
783+
"http.response_content_length": 24604,
784+
"http.transfer_size": 24904
785785
},
786786
"hash": "b7d184affa2b21b2"
787787
},
@@ -806,9 +806,9 @@
806806
"parent_span_id": "829d17842d952371",
807807
"trace_id": "80972418b74940bda6977932055f7fcd",
808808
"data": {
809-
"Decoded Body Size": 25931,
810-
"Encoded Body Size": 9296,
811-
"Transfer Size": 300
809+
"http.decoded_response_content_length": 25931,
810+
"http.response_content_length": 9296,
811+
"http.transfer_size": 300
812812
},
813813
"hash": "35a63c8a85b1279a"
814814
},

‎src/sentry/data/samples/transaction-render-blocking-asset.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123
"parent_span_id": "d333ac34048040f7",
124124
"trace_id": "af6cd4ed98d1459a9d496071342ab3e7",
125125
"data": {
126-
"Encoded Body Size": 1000001,
126+
"http.response_content_length": 1000001,
127127
"duration": 1
128128
},
129129
"hash": "a8b09954a220aea9"

‎src/sentry/utils/performance_issues/detectors/large_payload_detector.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ def visit_span(self, span: Span) -> None:
2424
return
2525

2626
data = span.get("data", None)
27-
encoded_body_size = data and data.get("Encoded Body Size", None)
27+
encoded_body_size = data and (
28+
data.get("http.response_content_length", None) or data.get("Encoded Body Size")
29+
)
2830
if not (encoded_body_size):
2931
return
3032

‎src/sentry/utils/performance_issues/detectors/render_blocking_asset_span_detector.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,11 @@ def _is_blocking_render(self, span):
100100
return False
101101

102102
minimum_size_bytes = self.settings.get("minimum_size_bytes")
103-
encoded_body_size = data and data.get("Encoded Body Size", 0) or 0
103+
encoded_body_size = (
104+
data
105+
and (data.get("http.response_content_length", 0) or data.get("Encoded Body Size", 0))
106+
or 0
107+
)
104108
if encoded_body_size < minimum_size_bytes or encoded_body_size > self.MAX_SIZE_BYTES:
105109
return False
106110

‎src/sentry/utils/performance_issues/detectors/uncompressed_asset_detector.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,16 @@ def visit_span(self, span: Span) -> None:
3636
return
3737

3838
data = span.get("data", None)
39-
transfer_size = data and data.get("Transfer Size", None)
40-
encoded_body_size = data and data.get("Encoded Body Size", None)
41-
decoded_body_size = data and data.get("Decoded Body Size", None)
39+
transfer_size = data and (
40+
data.get("http.transfer_size", None) or data.get("Transfer Size", None)
41+
)
42+
encoded_body_size = data and (
43+
data.get("http.response_content_length", None) or data.get("Encoded Body Size", None)
44+
)
45+
decoded_body_size = data and (
46+
data.get("http.decoded_response_content_length", None)
47+
or data.get("Decoded Body Size", None)
48+
)
4249
if not (encoded_body_size and decoded_body_size and transfer_size):
4350
return
4451

‎tests/sentry/utils/performance_issues/test_large_http_payload_detector.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ def test_detects_large_http_payload_issue(self):
3636
"GET /api/0/organizations/endpoint1",
3737
"hash1",
3838
data={
39-
"Transfer Size": 50_000_000,
40-
"Encoded Body Size": 50_000_000,
41-
"Decoded Body Size": 50_000_000,
39+
"http.transfer_size": 50_000_000,
40+
"http.response_content_length": 50_000_000,
41+
"http.decoded_response_content_length": 50_000_000,
4242
},
4343
)
4444
]
@@ -70,9 +70,9 @@ def test_does_not_issue_if_url_is_an_asset(self):
7070
desc="https://s1.sentry-cdn.com/_static/dist/sentry/entrypoints/app.js",
7171
duration=1000.0,
7272
data={
73-
"Transfer Size": 50_000_000,
74-
"Encoded Body Size": 50_000_000,
75-
"Decoded Body Size": 50_000_000,
73+
"http.transfer_size": 50_000_000,
74+
"http.response_content_length": 50_000_000,
75+
"http.decoded_response_content_length": 50_000_000,
7676
},
7777
)
7878
]

0 commit comments

Comments
 (0)