Skip to content

Commit 0c6129b

Browse files
asottile-sentryarmenzg
authored andcommitted
ref: use named arguments for drf serializers (#53354)
see encode/django-rest-framework#7632 <!-- Describe your PR here. -->
1 parent 043abe7 commit 0c6129b

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/sentry/api/endpoints/organization_stats_v2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class OrgStatsQueryParamsSerializer(serializers.Serializer):
6666
)
6767

6868
groupBy = serializers.MultipleChoiceField(
69-
list(GROUPBY_MAP.keys()),
69+
choices=list(GROUPBY_MAP.keys()),
7070
required=True,
7171
help_text=(
7272
"can pass multiple groupBy parameters to group by multiple, e.g. `groupBy=project&groupBy=outcome` to group by multiple dimensions. "

src/sentry/replays/validators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class ReplayValidator(serializers.Serializer):
5353
required=False,
5454
)
5555
field = serializers.MultipleChoiceField(
56-
VALID_FIELD_SET,
56+
choices=VALID_FIELD_SET,
5757
help_text="Specifies a field that should be marshaled in the output. Invalid fields will be rejected.",
5858
required=False,
5959
)

src/sentry/scim/endpoints/teams.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161

6262
class SCIMTeamPatchOperationSerializer(serializers.Serializer):
6363
op = serializers.CharField(required=True)
64-
value = serializers.ListField(serializers.DictField(), allow_empty=True)
64+
value = serializers.JSONField(required=False)
6565
path = serializers.CharField(required=False)
6666
# TODO: define exact schema for value
6767
# TODO: actually use these in the patch request for validation
@@ -153,9 +153,9 @@ def on_results(results):
153153
request=inline_serializer(
154154
name="SCIMTeamRequestBody",
155155
fields={
156-
"schemas": serializers.ListField(serializers.CharField()),
156+
"schemas": serializers.ListField(child=serializers.CharField()),
157157
"displayName": serializers.CharField(),
158-
"members": serializers.ListField(serializers.IntegerField()),
158+
"members": serializers.ListField(child=serializers.IntegerField()),
159159
},
160160
),
161161
responses={

0 commit comments

Comments
 (0)