Revert "feat(flags): Store options changes in the audit log (#78622)"

This reverts commit 5f5d2ed.

Co-authored-by: cmanallen <[email protected]>

Author: getsentry-bot

src/sentry/flags/endpoints/hooks.py

@@ -1,3 +1,7 @@
+import datetime
+from typing import Any, TypedDict
+
+from rest_framework import serializers
 from rest_framework.request import Request
 from rest_framework.response import Response
 
@@ -7,12 +11,7 @@
 from sentry.api.base import Endpoint, region_silo_endpoint
 from sentry.api.bases.organization import OrganizationPermission
 from sentry.api.exceptions import ResourceDoesNotExist
-from sentry.flags.providers import (
-    DeserializationError,
-    InvalidProvider,
-    handle_provider_event,
-    write,
-)
+from sentry.flags.models import ACTION_MAP, CREATED_BY_TYPE_MAP, FlagAuditLogModel
 from sentry.models.organization import Organization
 from sentry.utils.sdk import bind_organization_context
 
@@ -66,9 +65,97 @@ def convert_args(
 
     def post(self, request: Request, organization: Organization, provider: str) -> Response:
         try:
-            write(handle_provider_event(provider, request.data, organization.id))
+            rows_data = handle_provider_event(provider, request.data, organization.id)
+            FlagAuditLogModel.objects.bulk_create(FlagAuditLogModel(**row) for row in rows_data)
             return Response(status=200)
         except InvalidProvider:
             raise ResourceDoesNotExist
         except DeserializationError as exc:
             return Response(exc.errors, status=400)
+
+
+"""Provider definitions.
+
+Provider definitions are pure functions. They accept data and return data. Providers do not
+initiate any IO operations. Instead they return commands in the form of the return type or
+an exception. These commands inform the caller (the endpoint defintion) what IO must be
+emitted to satisfy the request. This is done primarily to improve testability and test
+performance but secondarily to allow easy extension of the endpoint without knowledge of
+the underlying systems.
+"""
+
+
+class FlagAuditLogRow(TypedDict):
+    """A complete flag audit log row instance."""
+
+    action: int
+    created_at: datetime.datetime
+    created_by: str
+    created_by_type: int
+    flag: str
+    organization_id: int
+    tags: dict[str, Any]
+
+
+class DeserializationError(Exception):
+    """The request body could not be deserialized."""
+
+    def __init__(self, errors):
+        self.errors = errors
+
+
+class InvalidProvider(Exception):
+    """An unsupported provider type was specified."""
+
+    ...
+
+
+def handle_provider_event(
+    provider: str,
+    request_data: dict[str, Any],
+    organization_id: int,
+) -> list[FlagAuditLogRow]:
+    if provider == "flag-pole":
+        return handle_flag_pole_event(request_data, organization_id)
+    else:
+        raise InvalidProvider(provider)
+
+
+"""Flag pole provider definition.
+
+If you are not Sentry you will not ever use this driver. Metadata provider by flag pole is
+limited to what we can extract from the git repository on merge.
+"""
+
+
+class FlagPoleItemSerializer(serializers.Serializer):
+    action = serializers.ChoiceField(choices=("created", "updated"), required=True)
+    created_at = serializers.DateTimeField(required=True)
+    created_by = serializers.CharField(required=True)
+    flag = serializers.CharField(max_length=100, required=True)
+    tags = serializers.DictField(required=True)
+
+
+class FlagPoleSerializer(serializers.Serializer):
+    data = FlagPoleItemSerializer(many=True, required=True)  # type: ignore[assignment]
+
+
+def handle_flag_pole_event(
+    request_data: dict[str, Any], organization_id: int
+) -> list[FlagAuditLogRow]:
+    serializer = FlagPoleSerializer(data=request_data)
+    if not serializer.is_valid():
+        raise DeserializationError(serializer.errors)
+
+    return [
+        dict(
+            action=ACTION_MAP[validated_item["action"]],
+            created_at=validated_item["created_at"],
+            created_by=validated_item["created_by"],
+            created_by_type=CREATED_BY_TYPE_MAP["email"],
+            flag=validated_item["flag"],
+            organization_id=organization_id,
+            tags=validated_item["tags"],
+        )
+        for validated_item in serializer.validated_data["data"]
+    ]

src/sentry/flags/providers.py

@@ -424,20 +424,6 @@
     flags=FLAG_ALLOW_EMPTY | FLAG_PRIORITIZE_DISK | FLAG_AUTOMATOR_MODIFIABLE,
 )
 
-# Flag Options
-register(
-    "flags:options-audit-log-is-enabled",
-    default=True,
-    flags=FLAG_ALLOW_EMPTY | FLAG_PRIORITIZE_DISK | FLAG_AUTOMATOR_MODIFIABLE,
-    type=Bool,
-)
-register(
-    "flags:options-audit-log-organization-id",
-    default=None,
-    flags=FLAG_ALLOW_EMPTY | FLAG_PRIORITIZE_DISK | FLAG_AUTOMATOR_MODIFIABLE,
-    type=Int,
-)
-
 # Replay Options
 #
 # Replay storage backend configuration (only applicable if the direct-storage driver is used)

src/sentry/options/defaults.py

@@ -6,22 +6,16 @@
 
 class PresenterDelegator:
     def __init__(self, source: str) -> None:
-        from sentry.runner.commands.presenters.audit_log_presenter import AuditLogPresenter
-
         self._consolepresenter = ConsolePresenter()
 
         self._slackpresenter = None
         if WebhookPresenter.is_webhook_enabled():
             self._slackpresenter = WebhookPresenter(source)
-        if AuditLogPresenter.is_webhook_enabled():
-            self._auditlogpresenter = AuditLogPresenter(source)
 
     def __getattr__(self, attr: str) -> Any:
         def wrapper(*args: Any, **kwargs: Any) -> None:
             getattr(self._consolepresenter, attr)(*args, **kwargs)
             if self._slackpresenter:
                 getattr(self._slackpresenter, attr)(*args, **kwargs)
-            if self._auditlogpresenter:
-                getattr(self._auditlogpresenter, attr)(*args, **kwargs)
 
         return wrapper