Skip to content

Commit 3da0795

Browse files
markushipriscilawebdev
authored andcommitted
fix(insights-mobile-ui): Ellipsize txn links in tables (#73935)
Properly ellipsizes the screen/txn links inside the tables, for both app start and screen load module Before: <img width="220" alt="image" src="https://github.com/getsentry/sentry/assets/1411808/4d5a3a40-ccac-46f4-8545-5ff1a5f185f2"> After: <img width="300" alt="image" src="https://github.com/getsentry/sentry/assets/1411808/b2e06de1-9f19-4922-8f42-d5ad28af0751">
1 parent 4eac589 commit 3da0795

File tree

2 files changed

+28
-24
lines changed

2 files changed

+28
-24
lines changed

static/app/views/insights/mobile/appStarts/components/tables/screensTable.tsx

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
PRIMARY_RELEASE_ALIAS,
1414
SECONDARY_RELEASE_ALIAS,
1515
} from 'sentry/views/insights/common/components/releaseSelector';
16+
import {OverflowEllipsisTextContainer} from 'sentry/views/insights/common/components/textAlign';
1617
import {useReleaseSelection} from 'sentry/views/insights/common/queries/useReleases';
1718
import {useModuleURL} from 'sentry/views/insights/common/utils/useModuleURL';
1819
import Breakdown from 'sentry/views/insights/mobile/appStarts/components/breakdown';
@@ -76,18 +77,19 @@ export function AppStartScreens({data, eventView, isLoading, pageLinks}: Props)
7677
return (
7778
<Fragment>
7879
<TopResultsIndicator count={TOP_SCREENS} index={index} />
79-
<Link
80-
to={`${moduleURL}/spans/?${qs.stringify({
81-
...location.query,
82-
project: row['project.id'],
83-
transaction: row.transaction,
84-
primaryRelease,
85-
secondaryRelease,
86-
})}`}
87-
style={{display: `block`, width: `100%`}}
88-
>
89-
{row.transaction}
90-
</Link>
80+
<OverflowEllipsisTextContainer>
81+
<Link
82+
to={`${moduleURL}/spans/?${qs.stringify({
83+
...location.query,
84+
project: row['project.id'],
85+
transaction: row.transaction,
86+
primaryRelease,
87+
secondaryRelease,
88+
})}`}
89+
>
90+
{row.transaction}
91+
</Link>
92+
</OverflowEllipsisTextContainer>
9193
</Fragment>
9294
);
9395
}

static/app/views/insights/mobile/screenload/components/tables/screensTable.tsx

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import {
2828
PRIMARY_RELEASE_ALIAS,
2929
SECONDARY_RELEASE_ALIAS,
3030
} from 'sentry/views/insights/common/components/releaseSelector';
31+
import {OverflowEllipsisTextContainer} from 'sentry/views/insights/common/components/textAlign';
3132
import {useReleaseSelection} from 'sentry/views/insights/common/queries/useReleases';
3233
import {useModuleURL} from 'sentry/views/insights/common/utils/useModuleURL';
3334
import useCrossPlatformProject from 'sentry/views/insights/mobile/common/queries/useCrossPlatformProject';
@@ -98,18 +99,19 @@ export function ScreensTable({data, eventView, isLoading, pageLinks, onCursor}:
9899
return (
99100
<Fragment>
100101
<TopResultsIndicator count={TOP_SCREENS} index={index} />
101-
<Link
102-
to={`${moduleURL}/spans/?${qs.stringify({
103-
...location.query,
104-
project: row['project.id'],
105-
transaction: row.transaction,
106-
primaryRelease,
107-
secondaryRelease,
108-
})}`}
109-
style={{display: `block`, width: `100%`}}
110-
>
111-
{row.transaction}
112-
</Link>
102+
<OverflowEllipsisTextContainer>
103+
<Link
104+
to={`${moduleURL}/spans/?${qs.stringify({
105+
...location.query,
106+
project: row['project.id'],
107+
transaction: row.transaction,
108+
primaryRelease,
109+
secondaryRelease,
110+
})}`}
111+
>
112+
{row.transaction}
113+
</Link>
114+
</OverflowEllipsisTextContainer>
113115
</Fragment>
114116
);
115117
}

0 commit comments

Comments
 (0)