Skip to content

Commit 7977d61

Browse files
authored
disable button (#19623)
1 parent 8f73bc3 commit 7977d61

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/sentry/static/sentry/app/views/settings/incidentRules/metricField.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const help = ({name, model}: {name: string; model: FormModel}) => {
6060
<Tooltip title={t('This preset is selected')} disabled={!preset.selected}>
6161
<PresetLink
6262
onClick={() => model.setValue(name, preset.default)}
63-
isSelected={preset.selected}
63+
disabled={preset.selected}
6464
>
6565
{preset.name}
6666
</PresetLink>
@@ -125,9 +125,9 @@ const AggregateHeader = styled('div')`
125125
margin-bottom: ${space(1)};
126126
`;
127127

128-
const PresetLink = styled(Button)<{isSelected: boolean}>`
128+
const PresetLink = styled(Button)<{disabled: boolean}>`
129129
${p =>
130-
p.isSelected &&
130+
p.disabled &&
131131
css`
132132
color: ${p.theme.gray700};
133133
&:hover,

tests/js/spec/views/settings/incidentRules/metricField.spec.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,13 @@ describe('MetricField', function() {
7474
);
7575
selectByLabel(wrapper, 'failure_rate()', {selector: 'QueryField'});
7676

77-
expect(wrapper.find('FieldHelp Button[isSelected=true]').text()).toEqual(
77+
expect(wrapper.find('FieldHelp Button[disabled=true]').text()).toEqual(
7878
'Failure rate'
7979
);
8080

8181
selectByLabel(wrapper, 'p95()', {selector: 'QueryField'});
8282

83-
expect(wrapper.find('FieldHelp Button[isSelected=true]').text()).toEqual('Latency');
83+
expect(wrapper.find('FieldHelp Button[disabled=true]').text()).toEqual('Latency');
8484
});
8585

8686
it('changes field values when selecting presets', function() {

0 commit comments

Comments
 (0)