ref: fix typing for sentry.tasks.process_buffer (#78644)

<!-- Describe your PR here. -->

Author: asottile-sentry

pyproject.toml

@@ -340,7 +340,6 @@ module = [
     "sentry.tagstore.types",
     "sentry.tasks.auth",
     "sentry.tasks.base",
-    "sentry.tasks.process_buffer",
     "sentry.testutils.cases",
     "sentry.testutils.fixtures",
     "sentry.testutils.helpers.notifications",

src/sentry/tasks/process_buffer.py

@@ -30,7 +30,7 @@ def process_pending() -> None:
 
     try:
         with lock.acquire():
-            buffer.process_pending()
+            buffer.backend.process_pending()
     except UnableToAcquireLock as error:
         logger.warning("process_pending.fail", extra={"error": error})
 
@@ -48,7 +48,7 @@ def process_pending_batch() -> None:
 
     try:
         with lock.acquire():
-            buffer.process_batch()
+            buffer.backend.process_batch()
     except UnableToAcquireLock as error:
         logger.warning("process_pending_batch.fail", extra={"error": error})
 
@@ -62,7 +62,7 @@ def process_incr(**kwargs):
 
     sentry_sdk.set_tag("model", kwargs.get("model", "Unknown"))
 
-    buffer.process(**kwargs)
+    buffer.backend.process(**kwargs)
 
 
 def buffer_incr(model, *args, **kwargs):
@@ -91,4 +91,4 @@ def buffer_incr_task(app_label, model_name, args, kwargs):
 
     sentry_sdk.set_tag("model", model_name)
 
-    buffer.incr(apps.get_model(app_label=app_label, model_name=model_name), *args, **kwargs)
+    buffer.backend.incr(apps.get_model(app_label=app_label, model_name=model_name), *args, **kwargs)

tests/sentry/buffer/test_redis.py

@@ -139,7 +139,7 @@ def test_group_cache_updated(self, default_group, task_runner):
             {"pk": default_group.id},
             {"last_seen": timezone.now()},
         )
-        with task_runner(), mock.patch("sentry.buffer", self.buf):
+        with task_runner(), mock.patch("sentry.buffer.backend", self.buf):
             self.buf.process_pending()
         group = Group.objects.get_from_cache(id=default_group.id)
         assert group.times_seen == orig_times_seen + times_seen_incr
@@ -452,7 +452,7 @@ def generate_group_queue(model_key: str) -> str | None:
             {"pk": default_group.id},
             {"last_seen": timezone.now()},
         )
-        with task_runner(), mock.patch("sentry.buffer", self.buf):
+        with task_runner(), mock.patch("sentry.buffer.backend", self.buf):
             self.buf.process_pending()
 
         assert len(mock_process_incr.apply_async.mock_calls) == 2
@@ -523,7 +523,7 @@ def generate_group_queue(model_key: str) -> str | None:
             {"pk": default_group.id + 2},
             {"last_seen": timezone.now()},
         )
-        with task_runner(), mock.patch("sentry.buffer", self.buf):
+        with task_runner(), mock.patch("sentry.buffer.backend", self.buf):
             self.buf.process_pending()
 
         assert len(mock_process_incr.apply_async.mock_calls) == 2
@@ -588,7 +588,7 @@ def generate_group_queue(model_key: str) -> str | None:
             {"pk": default_group.id},
             {"last_seen": timezone.now()},
         )
-        with task_runner(), mock.patch("sentry.buffer", self.buf):
+        with task_runner(), mock.patch("sentry.buffer.backend", self.buf):
             self.buf.process_pending()
 
         assert len(mock_process_incr.apply_async.mock_calls) == 2
@@ -619,7 +619,7 @@ def test_incr_uses_signal_only(self, default_group, task_runner):
             {"last_seen": timezone.now()},
             signal_only=True,
         )
-        with task_runner(), mock.patch("sentry.buffer", self.buf):
+        with task_runner(), mock.patch("sentry.buffer.backend", self.buf):
             self.buf.process_pending()
         group = Group.objects.get_from_cache(id=default_group.id)