Skip to content

Commit 1b0739c

Browse files
vulkan: fix typos in dequant shaders
1 parent cfd74c8 commit 1b0739c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

ggml/src/ggml-vulkan/vulkan-shaders/dequant_iq2_s.comp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ void main() {
2929
uint qs = data_a[ib].qs[4 * ib32 + l];
3030
const uint8_t sign = data_a[ib].qs[QUANT_K / 8 + 4 * ib32 + l];
3131
qs |= (qh << (8 - 2 * l)) & 0x300;
32-
const uvec2 grid = iq2s_grid[qs & 511];
32+
const uvec2 grid = iq2s_grid[qs];
3333
const u8vec4 grid0 = unpack8(grid.x);
3434
const u8vec4 grid1 = unpack8(grid.y);
3535
data_b[b_idx + 8 * l + 0] = D_TYPE(db[l/2] * grid0.x * ((sign & 1) != 0 ? -1.0 : 1.0));

ggml/src/ggml-vulkan/vulkan-shaders/dequant_iq3_s.comp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ void main() {
2222
const uint b_idx = 256 * ib + 32 * is;
2323

2424
const float d = float(data_a[ib].d);
25-
const float db = d * (1 + 2 * ((data_a[ib].scales[is] >> (4 * (is % 2))) & 0xf));
25+
const float db = d * (1 + 2 * ((data_a[ib].scales[is / 2] >> (4 * (is % 2))) & 0xf));
2626

2727
// We must produce 32 values using 4 sign bytes, 1 qh byte, 8 qs bytes.
2828
uint qh = data_a[ib].qh[is];
2929
[[unroll]] for (uint l = 0; l < 8; ++l) {
3030
uint qs = data_a[ib].qs[8 * is + l];
3131
uint gidx = qs | ((qh << (8 - l)) & 256);
32-
uint8_t signs = data_a[ib].signs[8 * is + l / 2] >> (4 * (l & 1));
32+
uint8_t signs = data_a[ib].signs[4 * is + l / 2] >> (4 * (l & 1));
3333
u8vec4 grid = unpack8(iq3s_grid[gidx]);
3434
data_b[b_idx + 4 * l + 0] = D_TYPE(db * grid.x * ((signs & 1) != 0 ? -1.0 : 1.0));
3535
data_b[b_idx + 4 * l + 1] = D_TYPE(db * grid.y * ((signs & 2) != 0 ? -1.0 : 1.0));

0 commit comments

Comments
 (0)