Fix condition for reading feature layers

alex-jw-brooks · alex-jw-brooks · commit 1dfebf0a0039 · 2025-02-12T16:12:07.000-07:00
Signed-off-by: Alex-Brooks &lt;Alex.Brooks@ibm.com&gt;
diff --git a/examples/llava/clip.cpp b/examples/llava/clip.cpp
@@ -1496,7 +1496,7 @@ struct clip_ctx * clip_model_load(const char * fname, const int verbosity = 1) {
 
             const int32_t * vision_feature_layer = (const int32_t *)gguf_get_arr_data(ctx, idx);
 
-            for (int i = 0; i < MAX_IMAGE_FEATURE_LAYERS && i < n && vision_feature_layer[i] != 0; ++i) {
+            for (int i = 0; i < MAX_IMAGE_FEATURE_LAYERS && i < n && vision_feature_layer[i] >= 0; ++i) {
                 hparams.vision_feature_layer[i] = vision_feature_layer[i];
             }
             if (n < MAX_IMAGE_FEATURE_LAYERS)

Original file line number	Diff line number	Diff line change
`@@ -1496,7 +1496,7 @@ struct clip_ctx * clip_model_load(const char * fname, const int verbosity = 1) {`
`1496`	`1496`
`1497`	`1497`	`const int32_t * vision_feature_layer = (const int32_t *)gguf_get_arr_data(ctx, idx);`
`1498`	`1498`
`1499`		`- for (int i = 0; i < MAX_IMAGE_FEATURE_LAYERS && i < n && vision_feature_layer[i] != 0; ++i) {`
	`1499`	`+ for (int i = 0; i < MAX_IMAGE_FEATURE_LAYERS && i < n && vision_feature_layer[i] >= 0; ++i) {`
`1500`	`1500`	`hparams.vision_feature_layer[i] = vision_feature_layer[i];`
`1501`	`1501`	`}`
`1502`	`1502`	`if (n < MAX_IMAGE_FEATURE_LAYERS)`