Skip to content

Commit 3ccbfe5

Browse files
authored
ci : remove xframework upload (#12190)
* ci : remove xframework upload This commit removes the upload of the xframework zip file as an artifact. The motivation for this change is that the xframework zip file is currently being uploaded as part of strategy and will therefore be attempted to be uploaded multiple times and will fail the build. The uploading should be moved to somewhere else in the build to avoid this. * ci : add xcframework upload to macos-latest job
1 parent 06a92a1 commit 3ccbfe5

File tree

1 file changed

+25
-25
lines changed

1 file changed

+25
-25
lines changed

.github/workflows/build.yml

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -716,31 +716,6 @@ jobs:
716716
run: |
717717
./build-xcframework.sh
718718
719-
- name: Determine tag name
720-
id: tag
721-
shell: bash
722-
run: |
723-
BUILD_NUMBER="$(git rev-list --count HEAD)"
724-
SHORT_HASH="$(git rev-parse --short=7 HEAD)"
725-
if [[ "${{ env.BRANCH_NAME }}" == "master" ]]; then
726-
echo "name=b${BUILD_NUMBER}" >> $GITHUB_OUTPUT
727-
else
728-
SAFE_NAME=$(echo "${{ env.BRANCH_NAME }}" | tr '/' '-')
729-
echo "name=${SAFE_NAME}-b${BUILD_NUMBER}-${SHORT_HASH}" >> $GITHUB_OUTPUT
730-
fi
731-
732-
- name: Pack artifacts
733-
id: pack_artifacts
734-
if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' }}
735-
run: |
736-
zip -r llama-${{ steps.tag.outputs.name }}-xcframework.zip build-apple/llama.xcframework
737-
738-
- name: Upload artifacts
739-
if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' }}
740-
uses: actions/upload-artifact@v4
741-
with:
742-
path: llama-${{ steps.tag.outputs.name }}-xcframework.zip
743-
744719
windows-msys2:
745720
runs-on: windows-latest
746721

@@ -1369,6 +1344,31 @@ jobs:
13691344
- name: Build Xcode project
13701345
run: xcodebuild -project examples/llama.swiftui/llama.swiftui.xcodeproj -scheme llama.swiftui -sdk iphoneos CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= -destination 'generic/platform=iOS' FRAMEWORK_FOLDER_PATH=./build-ios build
13711346

1347+
- name: Determine tag name
1348+
id: tag
1349+
shell: bash
1350+
run: |
1351+
BUILD_NUMBER="$(git rev-list --count HEAD)"
1352+
SHORT_HASH="$(git rev-parse --short=7 HEAD)"
1353+
if [[ "${{ env.BRANCH_NAME }}" == "master" ]]; then
1354+
echo "name=b${BUILD_NUMBER}" >> $GITHUB_OUTPUT
1355+
else
1356+
SAFE_NAME=$(echo "${{ env.BRANCH_NAME }}" | tr '/' '-')
1357+
echo "name=${SAFE_NAME}-b${BUILD_NUMBER}-${SHORT_HASH}" >> $GITHUB_OUTPUT
1358+
fi
1359+
1360+
- name: Pack artifacts
1361+
id: pack_artifacts
1362+
if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' }}
1363+
run: |
1364+
zip -r llama-${{ steps.tag.outputs.name }}-xcframework.zip build-apple/llama.xcframework
1365+
1366+
- name: Upload artifacts
1367+
if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' }}
1368+
uses: actions/upload-artifact@v4
1369+
with:
1370+
path: llama-${{ steps.tag.outputs.name }}-xcframework.zip
1371+
13721372
android-build:
13731373
runs-on: ubuntu-latest
13741374

0 commit comments

Comments
 (0)