Skip to content

Commit 437d2d6

Browse files
committed
dev : add reminders to update backends
ggml-ci
1 parent 572446b commit 437d2d6

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

ggml-kompute.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1680,6 +1680,9 @@ static void ggml_vk_graph_compute(struct ggml_kompute_context * ctx, struct ggml
16801680
#pragma message(" https://github.com/ggerganov/llama.cpp/pull/7225")
16811681
GGML_ASSERT(dst->src[2] == nullptr && "phi3 frequency factors not implemented yet");
16821682

1683+
#pragma message("TODO: update rope NORM mode to match NEOX mode")
1684+
#pragma message(" https://github.com/ggerganov/llama.cpp/pull/7634")
1685+
16831686
GGML_ASSERT(ne10 == ne02);
16841687
GGML_ASSERT(src0t == dstt);
16851688
// const int n_past = ((int32_t *) dst->op_params)[0];

ggml-sycl.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14029,6 +14029,9 @@ inline void ggml_sycl_op_rope(const ggml_tensor *src0, const ggml_tensor *src1,
1402914029

1403014030
const bool is_neox = mode & 2;
1403114031

14032+
#pragma message("TODO: update rope NORM mode to match NEOX mode")
14033+
#pragma message(" https://github.com/ggerganov/llama.cpp/pull/7634")
14034+
1403214035
if (is_neox) {
1403314036
pos = (const int32_t *) src1_dd;
1403414037

ggml-vulkan.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4303,6 +4303,9 @@ static void ggml_vk_rope(ggml_backend_vk_context * ctx, vk_context * subctx, con
43034303

43044304
const bool is_neox = mode & 2;
43054305

4306+
#pragma message("TODO: update rope NORM mode to match NEOX mode")
4307+
#pragma message(" https://github.com/ggerganov/llama.cpp/pull/7634")
4308+
43064309
float corr_dims[2];
43074310
ggml_rope_yarn_corr_dims(n_dims, n_ctx_orig, freq_base, beta_fast, beta_slow, corr_dims);
43084311

0 commit comments

Comments
 (0)