llama : define non-positive top_k; top_k range check (#779)

ivanstepanovftw · ggerganov · web-flow · commit 5a8c4f624077 · 2023-04-05T19:20:05.000+03:00
* Define non-positive top_k; top_k range check

* minor : brackets

---------

Co-authored-by: Georgi Gerganov &lt;ggerganov@gmail.com&gt;
diff --git a/llama.cpp b/llama.cpp
@@ -1229,7 +1229,9 @@ static llama_vocab::id llama_sample_top_p_top_k(
         }
     }
 
-    sample_top_k(logits_id, top_k);
+    if (top_k > 0 && top_k < n_logits) {
+        sample_top_k(logits_id, top_k);
+    }
 
     float maxl = -std::numeric_limits<float>::infinity();
     for (const auto & kv : logits_id) {

Original file line number	Diff line number	Diff line change
`@@ -1229,7 +1229,9 @@ static llama_vocab::id llama_sample_top_p_top_k(`
`1229`	`1229`	`}`
`1230`	`1230`	`}`
`1231`	`1231`
`1232`		`- sample_top_k(logits_id, top_k);`
	`1232`	`+ if (top_k > 0 && top_k < n_logits) {`
	`1233`	`+ sample_top_k(logits_id, top_k);`
	`1234`	`+ }`
`1233`	`1235`
`1234`	`1236`	`float maxl = -std::numeric_limits<float>::infinity();`
`1235`	`1237`	`for (const auto & kv : logits_id) {`