Skip to content

Commit 5a9e2f6

Browse files
authored
py : minor fixes (#5668)
1 parent 373ee3f commit 5a9e2f6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

convert-hf-to-gguf.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,8 @@ def set_gguf_parameters(self):
655655
self.gguf_writer.add_feed_forward_length(self.hparams["intermediate_size"])
656656
self.gguf_writer.add_head_count(head_count)
657657
self.gguf_writer.add_head_count_kv(head_count_kv)
658+
# note: config provides rms norm but it is actually layer norm
659+
# ref: https://huggingface.co/OrionStarAI/Orion-14B-Chat/blob/276a17221ce42beb45f66fac657a41540e71f4f5/modeling_orion.py#L570-L571
658660
self.gguf_writer.add_layer_norm_eps(self.hparams["rms_norm_eps"])
659661

660662
def write_tensors(self):
@@ -1031,7 +1033,6 @@ def set_gguf_parameters(self):
10311033
self.gguf_writer.add_head_count_kv(head_count_kv)
10321034
self.gguf_writer.add_rope_freq_base(self.hparams["rope_theta"])
10331035
self.gguf_writer.add_layer_norm_eps(self.hparams["layer_norm_eps"])
1034-
self.gguf_writer.add_layer_norm_rms_eps(self.hparams["rms_norm_eps"])
10351036

10361037
def set_vocab(self):
10371038
self._set_vocab_sentencepiece()

0 commit comments

Comments
 (0)