ggml : fix nullptr derefs in GGML_OP_CONT and GGML_OP_RESHAPE back

ggerganov · ggerganov · commit 6cc42deda511 · 2023-05-08T18:50:04.000+03:00
diff --git a/ggml.c b/ggml.c
@@ -13891,9 +13891,6 @@ static void ggml_compute_backward(struct ggml_context * ctx, struct ggml_tensor
                     GGML_ASSERT(ggml_is_contiguous(tensor->grad));
                     src0->grad = ggml_add_impl(ctx, src0->grad, tensor->grad, inplace);
                 }
-                if (src1->grad) {
-                    // noop
-                }
             } break;
         case GGML_OP_RESHAPE:
             {
@@ -13904,9 +13901,6 @@ static void ggml_compute_backward(struct ggml_context * ctx, struct ggml_tensor
                             ggml_reshape(ctx, tensor->grad, src0->grad),
                         inplace);
                 }
-                if (src1->grad) {
-                    // noop
-                }
             } break;
         case GGML_OP_VIEW:
             {

Original file line number	Diff line number	Diff line change
`@@ -13891,9 +13891,6 @@ static void ggml_compute_backward(struct ggml_context * ctx, struct ggml_tensor`
`13891`	`13891`	`GGML_ASSERT(ggml_is_contiguous(tensor->grad));`
`13892`	`13892`	`src0->grad = ggml_add_impl(ctx, src0->grad, tensor->grad, inplace);`
`13893`	`13893`	`}`
`13894`		`- if (src1->grad) {`
`13895`		`- // noop`
`13896`		`- }`
`13897`	`13894`	`} break;`
`13898`	`13895`	`case GGML_OP_RESHAPE:`
`13899`	`13896`	`{`
`@@ -13904,9 +13901,6 @@ static void ggml_compute_backward(struct ggml_context * ctx, struct ggml_tensor`
`13904`	`13901`	`ggml_reshape(ctx, tensor->grad, src0->grad),`
`13905`	`13902`	`inplace);`
`13906`	`13903`	`}`
`13907`		`- if (src1->grad) {`
`13908`		`- // noop`
`13909`		`- }`
`13910`	`13904`	`} break;`
`13911`	`13905`	`case GGML_OP_VIEW:`
`13912`	`13906`	`{`