Skip to content

Commit 829c480

Browse files
committed
ggml : fix Q4_3 scalar imlpementation
1 parent 5425e06 commit 829c480

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

ggml.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2990,9 +2990,6 @@ static void ggml_vec_dot_q4_3_q8_0(const int n, float * restrict s, const void *
29902990
const float d1 = GGML_FP16_TO_FP32(x[2*i + 1].d);
29912991
const float m1 = GGML_FP16_TO_FP32(x[2*i + 1].m);
29922992

2993-
int sy_0 = 0;
2994-
int sy_1 = 0;
2995-
29962993
int sxy_0 = 0;
29972994
int sxy_1 = 0;
29982995

@@ -3012,15 +3009,11 @@ static void ggml_vec_dot_q4_3_q8_0(const int n, float * restrict s, const void *
30123009
const int y0_1 = y0[2*(j + QK8_0/4) + 0];
30133010
const int y1_1 = y0[2*(j + QK8_0/4) + 1];
30143011

3015-
sy_0 += y0_0 + y1_0;
3016-
sy_1 += y0_1 + y1_1;
3017-
30183012
sxy_0 += x0_0*y0_0 + x1_0*y1_0;
30193013
sxy_1 += x0_1*y0_1 + x1_1*y1_1;
30203014
}
30213015

3022-
sumf += (d0*sxy_0 + m0*sy_0)*y[i].d;
3023-
sumf += (d1*sxy_1 + m1*sy_1)*y[i].d;
3016+
sumf += (d0*sxy_0 + d1*sxy_1)*y[i].d + m0*y[i].s0 + m1*y[i].s1;
30243017
}
30253018
*s = sumf;
30263019
#endif

0 commit comments

Comments
 (0)