USE MAX_IMAGE_FEATURE_LAYERS const in layer calc

alex-jw-brooks · alex-jw-brooks · commit 8d0195fcbfd9 · 2025-02-12T14:11:26.000-07:00
Signed-off-by: Alex-Brooks &lt;Alex.Brooks@ibm.com&gt;
diff --git a/examples/llava/clip.cpp b/examples/llava/clip.cpp
@@ -3001,7 +3001,7 @@ int get_deepest_feature_layer(const struct clip_ctx * ctx) {
     }
 
     // If we set explicit vision feature layers, only go up to the deepest one
-    for (int i = 0; i < 4; i++) {
+    for (int i = 0; i < MAX_IMAGE_FEATURE_LAYERS; i++) {
         if (ctx->vision_model.hparams.vision_feature_layer[i] > deepest_feature_layer) {
             deepest_feature_layer = ctx->vision_model.hparams.vision_feature_layer[i];
         }

Original file line number	Diff line number	Diff line change
`@@ -3001,7 +3001,7 @@ int get_deepest_feature_layer(const struct clip_ctx * ctx) {`
`3001`	`3001`	`}`
`3002`	`3002`
`3003`	`3003`	`// If we set explicit vision feature layers, only go up to the deepest one`
`3004`		`- for (int i = 0; i < 4; i++) {`
	`3004`	`+ for (int i = 0; i < MAX_IMAGE_FEATURE_LAYERS; i++) {`
`3005`	`3005`	`if (ctx->vision_model.hparams.vision_feature_layer[i] > deepest_feature_layer) {`
`3006`	`3006`	`deepest_feature_layer = ctx->vision_model.hparams.vision_feature_layer[i];`
`3007`	`3007`	`}`